2056732 - automatically download smart tab grouping models without extra opt-in for smart window auto tab grouping

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement)

Description

[Ed Lee :Mardak]

bug 2054500 added the functionality sharing SmartTabGroupingManager.isEnabled which checks for optin originally needed for classic confirming models downloads, but smart window doesn't want that manual optin

although unclear what should happen if user already has models downloaded for smart window and then wants to use classic smart tab grouping?

Comment 1

[Ed Lee :Mardak]

lazy download on first button click might be fine to start? if the delay is too long, then we could download during onboarding or switch or generally smart window init?

Comment 2

[:jlewis]

Attachment: Bug 2056732 - automatically download smart tab grouping models for Auto Tab Grouping

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a87c3e75838d
https://hg.mozilla.org/integration/autoland/rev/30e5fc4d0ec4
automatically download smart tab grouping models for Auto Tab Grouping r=Mardak,tabbrowser-reviewers,niklas

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7bf0e49b7b15
https://hg.mozilla.org/integration/autoland/rev/c949c95df9b3
Revert "Bug 2056732 - automatically download smart tab grouping models for Auto Tab Grouping r=Mardak,tabbrowser-reviewers,niklas" for causing multiple bc failures

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing multiple bc failures

Backout link

Push with failures

Logs can be found for each individual test by clicking on them + L shortcut.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f408c70154d5
https://hg.mozilla.org/integration/autoland/rev/9364fd1dcbc0
automatically download smart tab grouping models for Auto Tab Grouping r=Mardak,tabbrowser-reviewers,niklas

Comment 7

[:jlewis]

Fixed, sorry and thanks!

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9364fd1dcbc0

Comment 9

[:jlewis]

Attachment: Bug 2056732 - automatically download smart tab grouping models for Auto Tab Grouping

Original Revision: https://phabricator.services.mozilla.com/D315309

Comment 10

[:jlewis]

Attachment: Bug 2056732 - automatically download smart tab grouping models for Auto Tab Grouping

Original Revision: https://phabricator.services.mozilla.com/D315309

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/bc27a4a1fda0
https://hg.mozilla.org/releases/mozilla-beta/rev/2ffe99a90622

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/6ac26ea20d16
https://hg.mozilla.org/releases/mozilla-release/rev/3347336f6d72