2056877 - Share code to set-up prologue for GenerateCallablePrologue and GenerateJitEntryPrologue

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement)

Description

[André Bargull [:anba]]

For all architectures except ARM64, GenerateCallablePrologue and GenerateJitEntryPrologue emitted the same code to set-up the prologue, but confusingly used different MacroAssembler methods to make it more difficult to see that the same instructions are emitted.

Move the code to create the prologue into GenerateCommonPrologue and call that function from GenerateCallablePrologue and GenerateJitEntryPrologue.

Additionally for RISCV64, emit a smaller instruction sequence to create the prologue, matching what's used by Clang/GCC.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2056877: Share code to set-up prologue for GenerateCallablePrologue and GenerateJitEntryPrologue. r=#spidermonkey-reviewers!

For all architectures except ARM64, GenerateCallablePrologue and
GenerateJitEntryPrologue emitted the same code to set-up the prologue, but
confusingly used different MacroAssembler methods to make it more difficult
to see that the same instructions are emitted.

Move the code to create the prologue into GenerateCommonPrologue and call
that function from GenerateCallablePrologue and GenerateJitEntryPrologue.

Additionally for RISCV64, emit a smaller instruction sequence to create the
prologue, matching what's used by Clang/GCC.

Before:

addi      sp, sp, -8
sd        ra, 0(sp)
addi      sp, sp, -8
sd        fp, 0(sp)
mv        fp, sp

After:

addi      sp, sp, -16
sd        ra, 8(sp)
sd        fp, 0(sp)
mv        fp, sp

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d122bda56578
https://hg.mozilla.org/integration/autoland/rev/7386f182252d
Share code to set-up prologue for GenerateCallablePrologue and GenerateJitEntryPrologue. r=spidermonkey-reviewers,jandem

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7386f182252d