2056956 - Region Gate the monitor feature region US

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement)

Description

[Nick]

From Ed - "region or locale check can be added separately as those won’t work from the default pref firefox.js file anyway. here’s an example of auto tab grouping adding a region check https://phabricator.services.mozilla.com/D312297 as a hardcoded disallow FR but review comments suggest it might want a pref controlled allow if that’s the actual desired product behavior

where each feature needs to decide what’s the right access points to control access/behaviors"

Additional notes -looks like the referenced patch above has changed from https://phabricator.services.mozilla.com/D312297?vs=on&id=1324655#toc... looks like we should possibly follow what STB is doing in https://searchfox.org/firefox-main/source/browser/components/tabbrowser/SmartTabGrouping.sys.mjs#333

 static get isAllowed() {
    return Services.locale.appLocaleAsBCP47.startsWith("en");
  }

Comment 1

[Nick]

update from ed "if it’s inclusive list, then it’s the opposite of link preview’s disallow list. but both patterns are in use in firefox just flip the condition. you can search for “region” in about:config to see various examples" So we do not want to look at language

Comment 2

[Nick]

Attachment: Bug 2056956 - Region Gate the monitor feature region US r=yjamora

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/78a797044d95
https://hg.mozilla.org/integration/autoland/rev/e2cef6a4f10f
Region Gate the monitor feature region US r=yjamora,fluent-reviewers,flod

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e2cef6a4f10f