2057032 - [IPProtection] Delay onboarding vpn card until fxa is ready

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Mike a [:mavduevskiy]]

There is a race condition between IPProtectionOnboardingPrompt and FxaAccountManager on start: the prompt might be shown while the account manager is still being initialized, so that by the time a user finishes auth flow, the toolkit code is never informed about an existing user, and won't be able to connect automatically.

We used to get stuck in connecting state - that was fixed in 2054812, but ideally we would minimize the amount of users that could would get an error & retry after finishing auth.

Comment 1

[Mike a [:mavduevskiy]]

Attachment: WIP: Bug 2057032 - Part 1: Delay vpn onboarding until acc manager is ready

Comment 2

[Mike a [:mavduevskiy]]

Attachment: WIP: Bug 2057032 - Part 2: Refactor extra account status enum into WarmingUp

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 2057032 - Make vpn onboarding wait past WarmingUp

Adding NoAccount state for the onboarding to distinguish between fxa
manager initializing and having no account at the app start.

Comment 4

[Mike a [:mavduevskiy]]

Attachment: verification_new1.mp4

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2050967

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e2f893c81ce3
https://hg.mozilla.org/integration/autoland/rev/51229955d824
Make vpn onboarding wait past WarmingUp r=android-reviewers,jonalmeida

Comment 7

[rperta]

Backed out for causing fenix failures
Backout link
Push with failures
Failure log(s)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5a1f79236f4d
https://hg.mozilla.org/integration/autoland/rev/6dda76b22387
Make vpn onboarding wait past WarmingUp r=android-reviewers,jonalmeida

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6dda76b22387

Comment 10

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 2057032 - Make vpn onboarding wait past WarmingUp

Adding NoAccount state for the onboarding to distinguish between fxa
manager initializing and having no account at the app start.

Original Revision: https://phabricator.services.mozilla.com/D313887

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/439cbedf7ef0
https://hg.mozilla.org/releases/mozilla-beta/rev/3f7149cf303e

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/eaa84adbcac3
https://hg.mozilla.org/releases/mozilla-beta/rev/9bc8144d3773

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9624396 [details]
Bug 2057032 - Make vpn onboarding wait past WarmingUp

Backed out for android failures

https://treeherder.mozilla.org/jobs?repo=mozilla-beta&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2Ccomponents%2Copt%2Cfeature-ipprotection%2Cbuild-components-feature-ipprotection%2Cb&fromchange=d2cfd77d700eeef54544d3fbfe3fdaffbcf7e9da

Comment 14

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 2057032 - Make vpn onboarding wait past WarmingUp

Adding NoAccount state for the onboarding to distinguish between fxa
manager initializing and having no account at the app start.

Original Revision: https://phabricator.services.mozilla.com/D313887

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0019166ff856
https://hg.mozilla.org/releases/mozilla-beta/rev/931b9ad8987a

Comment 16

[Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA]

Fix verified in Fx Nightly 155.0a1 (Build #2016178394) and Fx Beta 154.0b10 (Build #2016178218) using a Google Pixel 7a (Android 16). The race condition seems to be fixed.

• video - signed in to Sync with a FxA that signed in to VPN before
• video - signed in to Sync with a FxA that didn't signed in to VPN before