2057164 - Primary Password reprompt after cancelled on subsequent sync requests

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2053724

Comment 2

[Johannes [:joschmidt]]

Attachment: Bug 2057164 - Skip Rust logins sync while Primary Password is locked r=bdk

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/998102077320
https://hg.mozilla.org/integration/autoland/rev/eb80b5c63625
Skip Rust logins sync while Primary Password is locked r=bdk,sync-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/eb80b5c63625

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/eb80b5c63625

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:joschmidt, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: With the Rust logins storage backend active (default), users who have set a Primary Password and use Sync get caught in a Primary Password prompt loop: after they cancel the prompt once, the Rust logins sync engine re-prompts on the very next scheduled sync (every few minutes) instead of backing off. The legacy JS backend went silent after a cancel and retried at the 15-minute master-password-locked interval; this patch restores that behaviour for the Rust backend.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Ensure the Rust logins storage is active (signon.storage.rust.active = true).

2. Set a Primary Password (about:preferences#privacy → "Use a Primary Password").
3. Sign in to a Firefox Account, enable Sync with Passwords syncing on.
4. Restart Firefox so the Primary Password is locked.
5. When the Primary Password prompt appears during a sync, click Cancel.
6. Expected (with fix): no further prompts for ~15 min; password sync silently backs off and resumes after you unlock. Without fix: the prompt reappears on every scheduled sync (every few minutes).

• Risk associated with taking this patch: low
• Explanation of risk level: Small, self-contained change: an early-return guard in RustPasswordEngine._sync() that only fires when the Primary Password is locked (!Services.logins.isLoggedIn). It touches only the Rust logins sync path (signon.storage.rust.active); the legacy backend and all other engines are unaffected. When unlocked, behaviour is unchanged (delegates to the normal sync). It reuses the existing, long-standing scheduler backoff (MASTER_PASSWORD_LOCKED / 15-min retry) rather than adding new machinery. Covered by a new xpcshell test.
• String changes made/needed?: None
• Is Android affected?: no

Comment 8

[Johannes [:joschmidt]]

Attachment: Bug 2057164 - Skip Rust logins sync while Primary Password is locked

Original Revision: https://phabricator.services.mozilla.com/D313691

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/489fcfb7613d
https://hg.mozilla.org/releases/mozilla-beta/rev/e756a2dbbb29