205717 - PK11_InitSlot should lock around the C_GetSlotInfo call

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Wan-Teh Chang]

PK11_InitSlot is not locking around the C_GetSlotInfo
call.  This is fine right now because we only initialize
NSS on one thread at startup (NSS only allows one instance
of NSS_Initialize at a time).  But it might be a good
idea to lock around the C_GetSlotInfo call anyway.

Comment 1

[Julien Pierre]

It seems this should be higher priority now that modules can dynamically add slots in PKCS#11 v2.20 . We have SECMOD_UpdateSlotList which may call PK11_InitSlot after NSS initialization, from multiple threads.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

John, do you think this might still be relevant?

Comment 4

[John Schanck [:jschanck]]

Yeah, this doesn't seem safe. And we have crash reports on that line. I'll switch this to a call to PK11_GetSlotInfo.

Comment 5

[John Schanck [:jschanck]]

Attachment: Bug 205717 - Use PK11_GetSlotInfo instead of raw C_GetSlotInfo calls. r=rrelyea

Comment 6

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/a9a8e1f8a252a6902d4acbe27120aa0dd42f7eab