2057370 - [Monitor Agent][FE] Monitor Card UI clean up

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement, P2)

Description

[Nick]

Couple follow-ups :

• I'd like to see the success/failure bool in the change history
• When editing, I'm surprised to still have the pause button.
• When editing, It might be nice to have a cancel button to basically undo anything I was messing around with instead of committing it with save
• The only way to get out of editing is to hit the pencil again. That's a bit unintuitive. I would have expected hitting save to also exit me out of the edit state

Comment 1

[Nick]

Attachment: Bug 2057370 - [Monitor Agent][FE] Monitor Card UI clean up r=yjamora

Ultimitly this patch is a catch all for a lot of small UX/UI changes called out by either tyler or taylor. This patch can see somewhat "all over the place" but these are small changes in a lot of places for the same goal to launch monitor in V0. Many of these small changes do not need thier own patch. Figma attached in description.

Additional notes from tyler :

I'd like to see the success/failure bool in the change history
When editing, I'm surprised to still have the pause button.
When editing, It might be nice to have a cancel button to basically undo anything I was messing around with instead of committing it with save
The only way to get out of editing is to hit the pencil again. That's a bit unintuitive. I would have expected hitting save to also exit me out of the edit state

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/07ff739560ce
https://hg.mozilla.org/integration/autoland/rev/411e8d1e2d39
[Monitor Agent][FE] Monitor Card UI clean up r=yjamora,fluent-reviewers,flod

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/411e8d1e2d39