2057393 - virtual keyboard might not work when opening a new window

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P1)

Description

[Makoto Kato [:m_kato]]

Step

1. Browse https://wontfix.net/bugs/2048921/
2. Click first [Popup] button
3. Set focus to input field on new window
4. Type something via virtual keyboard

Result

No typed character

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 2057393 - Set `GeckoEditableParent` if not set when taking a focus. r=#geckoview-reviewers!

When opening a new window, virtual keyboard might not work because
GeckoEditableParent is not set.

Normally, it is creates and attched with parent process when global document
is created. If it is too early, it is rarely failed since root window isn't
found yet.

We have a fallback path to create it when taking a IME focus, but it forget
attaching with parent process. So we should attach it on fallback path.

Comment 2

[Makoto Kato [:m_kato]]

regression range: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=37f1c536fdb89cd69039774a87f3ad8a94b95328&tochange=86c4f03a43058ea62f76021ad5a50e6199c34567 according to mozregression.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 543435

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/57e674a6df17
https://hg.mozilla.org/integration/autoland/rev/8813c7e52487
Set `GeckoEditableParent` if not set when taking a focus. r=geckoview-reviewers,owlish

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/8813c7e52487

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:m_kato, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 2057393 - Set `GeckoEditableParent` if not set when taking a focus.

When opening a new window, virtual keyboard might not work because
GeckoEditableParent is not set.

Normally, it is creates and attched with parent process when global document
is created. If it is too early, it is rarely failed since root window isn't
found yet.

We have a fallback path to create it when taking a IME focus, but it forget
attaching with parent process. So we should attach it on fallback path.

Original Revision: https://phabricator.services.mozilla.com/D313929

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: When creating new window by window.open, user cannot input any text in textbox on the new window.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Root cause is that a binder/IPC connection of text input is failed. This fix retries to create IPC connection when textbox is taking a focus if connection is nothing.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/86e40fd0288a
https://hg.mozilla.org/releases/mozilla-beta/rev/cb9048444118