2057411 - Bug 2057411 - [efficiency] Convert recently-closed tabs delete/open smoke tests to ui/efficiency

Status: RESOLVED FIXED

(Firefox for Android :: UI Tests, task)

Description

[Jackie Johnson]

Ports two RecentlyClosedTabsTest smoke tests:

• deleteRecentlyClosedTabsItemTest (TestRail 2195812)
• openRecentlyClosedItemTest (TestRail 1065414)
  Both green, non-flaky (pass on try #1).

Capability build for the recently-closed screen (previously only the empty state was modeled):

• RecentlyClosedTabsSelectors: add item-by-title (res-id title + text), item url (text-contains),
  the delete/overflow button, and an always-present toolbar-title arrival signal. Move the empty-state
  view out of requiredForPage into its own group so the page is reachable/assertable when populated.
• RecentlyClosedTabsPage: verifyRecentlyClosedItem / openRecentlyClosedItem / deleteRecentlyClosedItem /
  verifyEmptyRecentlyClosedList.
• Tests reuse on.tabDrawer.closeTabWithTitle + the on.home.navigateToPage() re-sync idiom (from HomeTest)
  to close the only tab and route to the recently-closed list.

Why: Ports the recently-closed delete/open smoke tests and models the populated recently-closed screen.

Context: part of the ui/efficiency UI-test modernization. This is a faithful port of an existing legacy ui/ smoke test onto the ui/efficiency framework — same coverage and assertions, but far less per-test code via a shared page-object / selector / navigation layer, which bends the UI-test maintenance cost curve. Smoke-conversion campaign (Program B), epic MTE-5504.

TestRail: 2195812, 1065414

Comment 1

[Jackie Johnson]

Attachment: Bug 2057411 - [efficiency] Convert recently-closed tabs delete/open smoke tests to ui/efficiency r=aaronmt,isabel_rios

Ports two RecentlyClosedTabsTest smoke tests:

• deleteRecentlyClosedTabsItemTest (TestRail 2195812)
• openRecentlyClosedItemTest (TestRail 1065414)
  Both green, non-flaky (pass on try #1).

Capability build for the recently-closed screen (previously only the empty state was modeled):

• RecentlyClosedTabsSelectors: add item-by-title (res-id title + text), item url (text-contains),
  the delete/overflow button, and an always-present toolbar-title arrival signal. Move the empty-state
  view out of requiredForPage into its own group so the page is reachable/assertable when populated.
• RecentlyClosedTabsPage: verifyRecentlyClosedItem / openRecentlyClosedItem / deleteRecentlyClosedItem /
  verifyEmptyRecentlyClosedList.
• Tests reuse on.tabDrawer.closeTabWithTitle + the on.home.navigateToPage() re-sync idiom (from HomeTest)
  to close the only tab and route to the recently-closed list.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6fe590930dad
https://hg.mozilla.org/integration/autoland/rev/50586dc73f23
[efficiency] Convert recently-closed tabs delete/open smoke tests to ui/efficiency r=aaronmt,isabel_rios

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/50586dc73f23