Closed Bug 2057428 Opened 12 days ago Closed 8 days ago

TCP socket created while speculative refuses a local (RFC1918) address and isn't retried after the attempt is claimed

Categories

(Core :: Networking: HTTP, defect, P2)

defect

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox155 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

When a HappyEyeballsConnectionAttempt creates its TCP socket while still speculative, the socket carries DISABLE_RFC1918, so nsSocketTransport::InitiateSocket refuses any RFC1918/local peer address synchronously with NS_ERROR_CONNECTION_REFUSED.
If the attempt is later claimed by a real transaction, that restriction should no longer apply, but we neither clear DISABLE_RFC1918 on the already-created socket nor re-drive the TCP connect.

Assignee: nobody → kershaw
Status: NEW → ASSIGNED
Pushed by kjang@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/aee531ac4103 https://hg.mozilla.org/integration/autoland/rev/a3f40e11543d Retry Happy Eyeballs for a claimed attempt that refused a local address, r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: