2057434 - Toolbox splitter aria-value(min|max) are only updated when the toolbox size changes

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

At the moment, we're only updating the aria-value(min|max) attributes of the splitter when the toolbox itself is resized
But there are different things that can happen that would impact the min/max value of the toolbox (and thus the value of those attributes):

• the browser gets resized (might impact the available width/height)
• the firefox sidebar is resized/toggled (impacts the available width)
• the find in page element is toggled (impacts the available height)
• notifications are added/removed into the page when split view is enabled (impacts the available height)
• RDM is toggled (impacts the available height)

---

Due to the work on the browserContainer layout in Bug 2049244, we might fix those issues there, but we should write tests for those different cases

Comment 1

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: Bug 2057434 - [devtools] Extend test coverage of DevTools toolbox splitter aria-value(min|max) attribute values. r=#devtools.

Make sure the attributes are properly updated whenever the available space for
the toolbox changes (e.g. the "Find in page" bar is toggled, notifications are
added in split view, RDM is toggled, Firefox sidebar is enabled, …)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/87c2c49197ed
https://hg.mozilla.org/integration/autoland/rev/199f91235633
[devtools] Extend test coverage of DevTools toolbox splitter aria-value(min|max) attribute values. r=devtools-reviewers,bomsy.

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/199f91235633