2057522 - browser_tabclose.js fails on macOS when browser.nova.enabled is true

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This bug covers excluded failing tests in the MANIFEST browser/base/content/test/performance/browser.toml
(generated by mach manifest skip-fails)

Comment 1

[Stephen Thompson [:sthompson]]

https://tests.firefox.dev/test.html?test=browser%2Fbase%2Fcontent%2Ftest%2Fperformance%2Fbrowser_tabclose.js and https://searchfox.org/firefox-main/rev/7f451c7918ffe36840b0ef31dfc2272ded671f81/browser/base/content/test/performance/browser.toml#80 suggest that this bug is about skipping macOS on Nova. It looks like the test has been succeeding on Linux 24.04 with Nova both enabled and disabled.

Let's retest this since bug 2055600 should have fixed this test.

Comment 2

[Michael Hynson]

Confirmed that this is fixed locally on macOS with Nova (Local results with browser.nova.enabled=true, macOS aarch64 (26.50)).

Comment 3

[Michael Hynson]

Attachment: Bug 2057522 - Re-enable browser_tabclose.js on macOS with Nova. r?#tabbrowser-reviewers

The skip was added by mach manifest skip-fails. Bug 2055600 fixed the test for Nova's changed tab strip dimensions. Also verified with a try push by temporarily adding the mochitest-browser-chrome to the macosx1500-aarch64 tests. I did this bc my machine architecture differed from what what in CI and the try push was an attempt to validate the skip removal on other architectures. Note: the extra commit is not a part of the patch but confirms the test passes and confirms the fix.

Comment 4

[Florian Quèze [:florian]]

(In reply to Michael Hynson from comment #3)

verified with a try push by temporarily adding the mochitest-browser-chrome to the macosx1500-aarch64 tests.

If you update your tree, you will no longer need this, bug 2062465 made this the default yesterday.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/11b0792e82d4
https://hg.mozilla.org/integration/autoland/rev/0344e33f82b5
Re-enable browser_tabclose.js on macOS with Nova. r=florian

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0344e33f82b5