2057690 - Configure Wikipedia search for Sardinian (sc) to use Sardinian wikipedia instead of Italian

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Bryan Olsson [:bolsson]]

When search features for the Sardinian locale (sc) were setup, they defaulted to Italian settings. The Sardinian locale has requested wikipedia searchs to use the Sardinian version of Wikipedia instead of Italian.

I believe we need to update remote settings search config to create a new entry for Sardinian (locale code "sc") under the Wikipedia search.

Wikipedia settings for Sardinian can be found below:
name: Wikipedia (sc)
url: https://sc.wikipedia.org/wiki/Ispetziale:Search
api: https://sc.wikipedia.org/w/api.php

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 2057690 - Add Wikipedia search for Sardinian. r?#search-reviewers!

Comment 2

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:standard8, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Mark Banner (:standard8)]

Expected as we're waiting for availability to stage on remote settings.

Comment 4

[Mark Banner (:standard8)]

This is now on remote settings staging, please could QA test?

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

QA has finished testing the new Wikipedia (sc) using RS stage as instructed.
The results of the testing activity can be viewed here. The Sardinian locale (sc) is correctly used for wikipedia searches. Wikipedia (sc) is used for the SC locale instead of Wikipediat (it).

This is ready for PROD push from QA perspective.

Comment 6

[Mark Banner (:standard8)]

This is now live on production as of about 14:42 UTC. Leaving open for the tests to land.

Comment 7

[Phabricator Automation]

firefox-esr153 Uplift Approval Request

• User impact if declined/Reason for urgency: Test-only change to support a search-config-v2 remote settings update.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: Test-only change
• String changes made/needed?: None
• Is Android affected?: no

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 2057690 - Add Wikipedia search for Sardinian.

Comment 9

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Test-only change to support a search-config-v2 remote settings update.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: Test-only change
• String changes made/needed?: None
• Is Android affected?: no

Comment 10

[Mark Banner (:standard8)]

Attachment: Bug 2057690 - Add Wikipedia search for Sardinian.

Comment 11

[Mark Banner (:standard8)]

Attachment: Bug 2057690 - Add Wikipedia search for Sardinian.

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Test-only change to support a search-config-v2 remote settings update.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: Test-only change
• String changes made/needed?: None
• Is Android affected?: no

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4f87860eb11c
https://hg.mozilla.org/releases/mozilla-beta/rev/0a0602b8ed0b

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a5be3e6db7eb
https://hg.mozilla.org/integration/autoland/rev/e2720bd23811
Add Wikipedia search for Sardinian. r=search-reviewers,scunnane

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e2720bd23811

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/bef882dfbd39

Comment 17

[Mark Banner (:standard8)]

Attachment: Bug 2057690 - Add Wikipedia search for Sardinian.

Comment 18

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined/Reason for urgency: Test-only change to support a search-config-v2 remote settings update.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: low
• Explanation of risk level: Test-only change
• String changes made/needed?: None
• Is Android affected?: no

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/e61bde8506bb

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8d742bcfc798
https://hg.mozilla.org/releases/mozilla-release/rev/8d987367ba2a