2057763 - Firefox Suggest will search instead of selecting an auto-filled result if Firefox was recently opened

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Justin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:153.0) Gecko/20100101 Firefox/153.0

Steps to reproduce:

I can reproduce the issue consistently:

1. Launch Firefox from being fully closed
2. Immediately type a letter into the address bar
3. Press down arrow and enter to select the first Firefox Suggest option

Actual results:

While typing r, http://reddit.com/ shows as the first result in my Firefox Suggest. Selecting this by using the arrow keys and enter should result in Reddit being loaded.

Expected results:

Firefox will ignore the selected suggested website from history and instead search for the letter r even though the website was selected. This issue resolves itself after Firefox is open for a short time. This is not behavior I have noticed in the past with Firefox after using it for ~20 years.

Comment 1

[Mark Banner (:standard8)]

Would you be able to record a short video of the issue? This will help us to diagnose where the issue might be.

Comment 2

[Justin]

(In reply to Mark Banner (:standard8) from comment #1)

Would you be able to record a short video of the issue? This will help us to diagnose where the issue might be.
Just a quick video to explain my issue. It's as simple as typing a search, quickly pressing the down arrow to selecting a option, and pressing enter. This only occurs when the browser is freshly opened so I figure it has some issue related to clicking the address bar before it's fully initialized, but it wasn't like this before.

https://streamable.com/larej5

Comment 3

[CalebChan]

The video link says unavailable, would you be able to attach another video?

Comment 4

[Justin]

(In reply to CalebChan from comment #3)

The video link says unavailable, would you be able to attach another video?

Sorry about that, I didn't know the video would expire so soon. Here's a youtube link
https://youtu.be/qA4hF0s6jmc

Comment 5

[Mandy Cheang [:mcheang][she/her]]

Hi daisuke,
Would this bug be related to one you worked on? Bug 2020177

Comment 6

[Daisuke Akatsuka (:daisuke)]

Thanks, Mandy! I will take a look.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2057763 - Keep a suggestion the user picked when a load finishes behind the open view.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7032032c6e8
https://hg.mozilla.org/integration/autoland/rev/13499d0a86f1
Keep a suggestion the user picked when a load finishes behind the open view. r=adw

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/13499d0a86f1

Comment 10

[Donal Meehan [:dmeehan]]

Did you want to nominate this for the Fx157 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

Fixed the address bar searching for what was typed instead of opening the suggestion that was selected, shortly after Firefox started.

Comment 11

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Donal!

Release Note Request (optional, but appreciated)
[Why is this notable]:
It searched for the typed characters instead of opening the suggestion the user had selected, discarding an explicit choice. Reproducible on every startup for the reporter.
[Affects Firefox for Android]:
None.
[Suggested wording]:
Fixed the address bar searching for the typed text instead of opening the selected suggestion when a page was still loading, such as shortly after Firefox started.
[Links (documentation, blog post, etc)]:
None.

Comment 12

[Dianna Smith [:diannaS]]

Added to 157 release notes