2057884 - Reenable browser_sandbox_test.js on Linux 22.04 when browser.nova.enabled is true

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, task)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Skip rule added: "os == 'linux' && os_version == '22.04' && arch == 'x86_64' && debug && nova",

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This bug reportedly affects only Linux 22.04. The test does not run with this environment in production by default and the failure might be an issue with the Wayland graphical display system on Linux. Feel free to remove the bug from blocking nova tests and to re-enable test. (This is message is an update to several bugs.)

Comment 2

[Jens Stutte [:jstutte]]

It feels highly unlikely that a front-end change like Nova could cause any problem with that test. And I miss any ancillary information about how this test is failing in this bug and Jed was not able to reproduce any failure.

Can we just re-enable it and see what happens? The bulk disabling happened in bug 2057902 but also there I cannot find any details about the why.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 2057884 - Reenable `browser_sandbox_test` under Nova. r?#sandbox-reviewers

Nova is a Firefox frontend revamp, and browser_sandbox_test is a suite
of lower-level sandbox policy tests written in C++, so any failures were
likely coincidental, and we should reenable the test and investigate any
new failures that result.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Jens Stutte [:jstutte] from comment #2)

Can we just re-enable it and see what happens?

As one of the sandboxing module owners: Yes, we can.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/28b5e86da948
https://hg.mozilla.org/integration/autoland/rev/2cf8eec95457
Reenable `browser_sandbox_test` under Nova. r=sandbox-reviewers,bobowen

Comment 6

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/2cf8eec95457