2057970 - border-style: double renders as single border with bad corner rounding

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Henri Sivonen (:hsivonen)]

Attachment: Firefox on left, Safari on right

Steps to reproduce

1. Load https://hsivonen.fi/ (tested on macOS)

Actual results

The border on the body element is a single thick border instead of being a double border. Instead of the corners being rounded, the corners show a blurry glitch.

Expected results

Expected the border in Firefox to look like the border in Safari.

Comment 1

[6k64x4ma]

I can reproduce this on Windows 11.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=63b2ec62d67e5073fa0b901c1c3c7efb8aa9bc07&tochange=9d3cec6ffc71f3e1659210135bc7415bdacc7d6d

Regressed by bug 2051358.

Comment 2

[Timothy Nikkel (:tnikkel)]

Thanks for the regression window, very helpful.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2051358

:nical, since you are the author of the regressor, bug 2051358, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 2057970 - Avoid large render tasks for non-dashed/dotted borders. r=#gfx-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d35afdb47a20
https://hg.mozilla.org/integration/autoland/rev/6dac6493b8fe
Avoid large render tasks for non-dashed/dotted borders. r=gfx-reviewers,gw

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6dac6493b8fe

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:nical, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 2057970 - (beta version) Avoid large render tasks for non-dashed/dotted borders. r=#gfx-reviewers

Comment 9

[Nicolas Silva [:nical]]

Attachment: Bug 2057970 - (beta version) Avoid large render tasks for non-dashed/dotted borders.

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Visual regressions
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Simple fix. I had to rebase manually because of a merge conflict in reftest manifests.
• String changes made/needed?: None.
• Is Android affected?: yes

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/30ebcf3d0649
https://hg.mozilla.org/releases/mozilla-beta/rev/16e3c24c24c6