Closed
Bug 2058024
Opened 2 months ago
Closed 22 days ago
[Nova] `Settings` link color from the history panel empty state does not respect Figma
Categories
(Firefox :: Sidebar, defect, P2)
Tracking
()
VERIFIED
FIXED
158 Branch
People
(Reporter: atrif, Assigned: kcochrane)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fidefe-sidebar][fidefe-nova])
Attachments
(3 files)
Found in
- 155.0a1 (2026-07-26)
Affected versions
- 155.0a1 (2026-07-26)
Tested platforms
- Affected platforms: Ubuntu 26, Windows 11, macOS 14 aarch
- Unaffected platforms:
Preconditions
- ensure Nova is enabled
- ensure that sidebar is enabled
- ensure no History is saved or the browser is set to never remember history
Steps to reproduce
- Open Sidebar > History panel.
Expected result
- The settings link color respects Figma https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=13136-117821&t=wM65OCZiLU23ezMV-0
Actual result
- The settings link color does not respect Figma.
Regression range
- N/A.
Additional notes
- Attached a screenshot.
Updated•2 months ago
|
| Reporter | ||
Comment 1•2 months ago
|
||
This also seems to reproduce for the connect additional devices link from the Tabs from other devices panel.
Comment 2•2 months ago
|
||
Appears that this panel is using fxview-empty-state.css. DevTools shows that --fxview-primary-action-background isn't set for sidebar panels.
Severity: -- → S3
Priority: -- → P2
Updated•2 months ago
|
Points: --- → 1
| Assignee | ||
Updated•27 days ago
|
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
| Assignee | ||
Comment 3•27 days ago
|
||
Pushed by kcochrane@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/7864854ce752
https://hg.mozilla.org/integration/autoland/rev/8e4283505234
Update color of empty state links in the sidebar r=desktop-theme-reviewers,fxview-reviewers,dao,nsharpley
Comment 5•22 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 22 days ago
status-firefox158:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
Updated•21 days ago
|
Updated•21 days ago
|
QA Contact: cbadau
Comment 6•21 days ago
|
||
Verified as fixed on Windows 11, Ubuntu 22 and macOS 13 using the latest Nightly 158.0a1 (2026-09-15).
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-found-in-c155] [S4][QA-5204] → [qa-found-in-c155] [S4][QA-5204][qa-ver-done-c158/b157]
You need to log in
before you can comment on or make changes to this bug.
Description
•