2058062 - Downloads and History windows go to full-screen mode instead of floating on top on macOS

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Vadim Makeev]

Attachment: downloads.mov

Steps to reproduce

• Go to the native full screen (Ctrl Cmd F)
• Open the History (Cmd Y) or the Downloads (Cmd J) window.

Expected behavior

A floating window opened on top of the current main window.

Actual behavior

A new proper app window opens and goes to its own full-screen space.

---

See the attached screen recording using the Downloads window as an example.

I believe it used to be different before Firefox 153, but also incorrect: app windows shouldn’t coexist in a full-screen mode. There’s a special kind of floating (secondary) window on macOS that can stay on top of the full-screen window. They should be used instead.

Comment 1

[Vadim Makeev]

Attachment: pages.mov

Examples of such floating windows in the Pages app: Fonts, Colors, etc.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 2058062 - Don't use Mac native fullscreen for the Library window. r=Standard8

Comment 4

[Marco Bonardo [:mak]]

I'll try this and see how it behaves.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bcf64db49d69
https://hg.mozilla.org/integration/autoland/rev/a62938eb1762
Don't use Mac native fullscreen for the Library window. r=Standard8,places-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a62938eb1762

Comment 7

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox156 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Marco Bonardo [:mak]]

we want to get feedback about the change first, so we'll let this ride naturally and not uplift.