2058063 - Remove getReleaseBranch() from the webcompat addon (and just use getEffectiveUpdateChannel())

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, defect)

Description

[:Gijs (he/him)]

https://searchfox.org/firefox-main/rev/4c201594e8be406786dd33b609429a29d5a10813/browser/extensions/webcompat/experiment-apis/appConstants.js#64

I don't know how this gets used and what should happen to it... Tom?

Comment 1

[Thomas Wisniewski [:twisniewski]]

We're not currently using it, but it's only meant to allow us to gate our SmartBlock shims by release branch. I believe we can just replace its use with a similar method, getEffectiveUpdateChannel. I could write a patch for that, if you'd like?

Comment 2

[:Gijs (he/him)]

(In reply to Thomas Wisniewski [:twisniewski] from comment #1)

We're not currently using it, but it's only meant to allow us to gate our SmartBlock shims by release branch. I believe we can just replace its use with a similar method, getEffectiveUpdateChannel. I could write a patch for that, if you'd like?

Sounds like a minimal fix would be to just remove the "early beta or earlier" branch from getReleaseBranch, so it will answer "release_or_beta" for early betas as well. I'd also be fine with removing getReleaseBranch entirely, and then as you say you could use the update channel. It's up to you. If we're needing to use these in interventions or somesuch to match preference / ifdef values from code (due to feature availability and such) it may be useful to keep getReleaseBranch and just omit the early_beta_or_earlier value from it.

Comment 3

[Thomas Wisniewski [:twisniewski]]

We sometimes need to gate our interventions by release branch (most often nightly) for testing, so being able to distinguish beta is also useful (even if we're not using it right now, and use it even less often for SmartBlock shims). It's all about having the flexibility, so it sounds like it would be best to just use the other method, and I don't mind making the change.

Comment 4

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2058063 - remove the webcompat addon's getReleaseBranch experimental API; r?ksenia!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0039bec640dd
https://hg.mozilla.org/integration/autoland/rev/1bb30c03a13e
remove the webcompat addon's getReleaseBranch experimental API; r=ksenia,webcompat-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1bb30c03a13e