2058283 - Navigating back in a custom tab closes a video in picture-in-picture mode

Status: RESOLVED FIXED

(Focus :: General, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: Screen_recording_20260727_155707.mp4

Prerequisite

• Make Focus your default browser.

Steps to reproduce

1. Navigate to youtube.com.
2. Start playing a video, make it fullscreen and press the home button, in order to put the video into PIP mode.
3. Go into another app that opens links in a custom tab (e.g. Gmail).
4. Click a link there.
5. When the page starts loading (or finishes loading), navigate back.
6. Observe the PIP window.

Expected results

• The PIP video should continue playing.

Actual results

• The PIP window is closed.

Additional information

• See attached video.
• Reproduced on Pixel 8a, Android 16.
• This is reproducible on 153 and 155 (nightly).

Comment 1

[Jonathan Almeida [:jonalmeida]]

This is an S2 because it leads to data loss without any recoverable options or workarounds.

Comment 2

[Jonathan Almeida [:jonalmeida]]

From a mozregression:

Newest known good nightly: 2024-08-20
Oldest known bad nightly: 2024-08-21

Comment 3

[Jonathan Almeida [:jonalmeida]]

Found the regressor.

The commenting out the one-liner fixes this bug and interesting also doesn't reproduce the original bug that the patch was solving, so something else in the system has changed to cover this case.

Comment 4

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 2058283 - Exit fullscreen for the provided tabId only r=pollymce

The regressor bug's STR do not seem to reproduce the bug anymore, so its
possible that another part of the system covers this case. In any case,
we can fix our bug by providing the tabId for the session we want to
exit instead of using default that closes the custom tab and the
selected tab at the same time.

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1892407

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c4dee71d1e0d
https://hg.mozilla.org/integration/autoland/rev/c5595e8d64de
Exit fullscreen for the provided tabId only r=android-reviewers,mcarare

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c5595e8d64de

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jonalmeida, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Jonathan Almeida [:jonalmeida]]

The bug has existed for almost a year, at this point, we can allow it to ride the trains.