2058311 - SW Organize Tabs v0 - UI Fixes for v0

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement, P1)

Comment 1

[:jlewis]

Attachment: Bug 2058311 - SW Auto Tab Grouping Styling, Menu Button Placement, Nova Tweaks r=#fluent-reviewers,#desktop-theme-reviewers,Mardak,dao,flod

The "Just created" rows drew their own rounded square, so they kept the
Proton shape under Nova and ignored the palette's dark-mode inversion.
Render tab-group-chicklet.svg instead, the same asset the tab strip and
the tab groups list use, which switches to the Nova shape on its own.

Comment 2

[:jlewis]

(In reply to :jlewis from comment #1)

Created attachment 9622136 [details]
WIP: Bug 2058311 - SW Auto Tab Grouping Nova

The "Just created" rows drew their own rounded square, so they kept the
Proton shape under Nova and ignored the palette's dark-mode inversion.
Render tab-group-chicklet.svg instead, the same asset the tab strip and
the tab groups list use, which switches to the Nova shape on its own.

Comment 3

[Ed Lee :Mardak]

bug 2066894 is running into upgrade issues with customizable ui

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3ce1e049826
https://hg.mozilla.org/integration/autoland/rev/1c0818ef5b9d
SW Auto Tab Grouping Styling, Menu Button Placement, Nova Tweaks r=fluent-reviewers,desktop-theme-reviewers,Mardak,dao,flod,kcochrane

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/63cf9cf6bc82
https://hg.mozilla.org/integration/autoland/rev/680b89264b28
Revert "Bug 2058311 - SW Auto Tab Grouping Styling, Menu Button Placement, Nova Tweaks r=fluent-reviewers,desktop-theme-reviewers,Mardak,dao,flod,kcochrane" for causing mochitest failures @ test_initialize_vertical_tabs.py

Comment 6

[pstanciu]

Backed out for causing mochitest failures @ test_initialize_vertical_tabs.py

• https://hg.mozilla.org/integration/autoland/rev/680b89264b2850dc6c5da49dd3f9ae0b805221a8
• Push with failures
• Failure Log

Comment 7

[:jlewis]

Ah, forgot to update a marionette test. Apologies and thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/53837142d475
https://hg.mozilla.org/integration/autoland/rev/2c75cc212c0b
SW Auto Tab Grouping Styling, Menu Button Placement, Nova Tweaks r=fluent-reviewers,desktop-theme-reviewers,Mardak,dao,flod,kcochrane

Comment 9

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/2c75cc212c0b

Comment 10

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/2c75cc212c0b