The default bug view has changed. See this FAQ.

"rightmargin" keyword seems to be ignored. there should be some white space between the right border and the text

RESOLVED FIXED

Status

()

Core
Layout: Block and Inline
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Kai Schröder, Assigned: Samuel Sieb)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507

In the page at http://www.visual-imagination.de/wir.html, the "rightmargin"
keyword seems to be ignored. it is written in capital letters in the html code,
but changing that to small letters doesn't help. there should be some white
space (50 pixels) between the right border and the text

Reproducible: Always

Steps to Reproduce:
1. just have a look at http://www.visual-imagination.de/wir.html
2.
3.

Comment 1

14 years ago
"rightmargin" is not part of the HTML specs.  It is an IE-only proprietary
attribute.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → INVALID
Reopening.  We support leftmargin and topmargin in quirks mode; I do not see a
reason to support those but not rightmargin....
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Well I can see _some_ reasons...
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 4

14 years ago
I think I can do this.
Assignee: block-and-inline → samuel
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Comment 5

14 years ago
Created attachment 123453 [details] [diff] [review]
add rightmargin property
(Assignee)

Comment 6

14 years ago
Who should review it?
Status: NEW → ASSIGNED
Comment on attachment 123453 [details] [diff] [review]
add rightmargin property

Any reason not to do bottommargin while you're here?
(Assignee)

Comment 8

14 years ago
Oh, I was thinking bottommargin wouldn't make sense and didn't know if it
existed. :-)  Patch coming up.
(Assignee)

Comment 9

14 years ago
Created attachment 123510 [details] [diff] [review]
now with bottommargin as well
Attachment #123453 - Attachment is obsolete: true
The bottommargin code gets the topmargin attribute in that patch....
Fix that?  ;)
(Assignee)

Comment 11

14 years ago
Created attachment 123527 [details] [diff] [review]
all the margins V3

C&P error.  And my testcase wasn't good enough... :-/
Attachment #123510 - Attachment is obsolete: true
Comment on attachment 123527 [details] [diff] [review]
all the margins V3

r+sr=me, but please hold off on this checkin
until dbaron lands his nsCSSDeclaration rewrite.  You'll
need to update to use nsCSSRect& instead of nsCSSRect* at that point, but that
should be simple.
Attachment #123527 - Flags: superreview+
Attachment #123527 - Flags: review+
(Assignee)

Comment 13

14 years ago
What's the bug # so I can watch for it?
Bug 125246.  Thanks for the patch, Samuel!
(Assignee)

Comment 15

14 years ago
Is the nsCSSDeclaration rewrite going to make it on the 1.4 branch?  Maybe this
could go on the branch but wait on the trunk?
That's certainly not going onto the branch.  If you can get approval, feel free
to land on the branch.
(Assignee)

Updated

14 years ago
Attachment #123527 - Flags: approval1.4?

Comment 17

14 years ago
Comment on attachment 123527 [details] [diff] [review]
all the margins V3

a=asa (on behalf of drivers) for checkin to the 1.4 branch.
Attachment #123527 - Flags: approval1.4? → approval1.4+
(Assignee)

Comment 18

14 years ago
checked into branch
Depends on: 125246
Keywords: fixed1.4
Feel free to land this on the trunk as well -- I can handle the merging needed.

Comment 20

14 years ago
Branch build 2003-06-12: Win2k, Mac 10.1.5
Branch build 2003-06-11: Linux RH 8
Marking Verified1.4.
It appears that this is fixed on the branch builds. I see a wider right margin
versus what is displayed in the trunk builds. 
Keywords: fixed1.4 → verified1.4
(Assignee)

Comment 21

14 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.