User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507 In the page at http://www.visual-imagination.de/wir.html, the "rightmargin" keyword seems to be ignored. it is written in capital letters in the html code, but changing that to small letters doesn't help. there should be some white space (50 pixels) between the right border and the text Reproducible: Always Steps to Reproduce: 1. just have a look at http://www.visual-imagination.de/wir.html 2. 3.
"rightmargin" is not part of the HTML specs. It is an IE-only proprietary attribute.
Reopening. We support leftmargin and topmargin in quirks mode; I do not see a reason to support those but not rightmargin....
Well I can see _some_ reasons...
I think I can do this.
Who should review it?
Comment on attachment 123453 [details] [diff] [review] add rightmargin property Any reason not to do bottommargin while you're here?
Oh, I was thinking bottommargin wouldn't make sense and didn't know if it existed. :-) Patch coming up.
Created attachment 123510 [details] [diff] [review] now with bottommargin as well
The bottommargin code gets the topmargin attribute in that patch.... Fix that? ;)
Created attachment 123527 [details] [diff] [review] all the margins V3 C&P error. And my testcase wasn't good enough... :-/
Comment on attachment 123527 [details] [diff] [review] all the margins V3 r+sr=me, but please hold off on this checkin until dbaron lands his nsCSSDeclaration rewrite. You'll need to update to use nsCSSRect& instead of nsCSSRect* at that point, but that should be simple.
What's the bug # so I can watch for it?
Bug 125246. Thanks for the patch, Samuel!
Is the nsCSSDeclaration rewrite going to make it on the 1.4 branch? Maybe this could go on the branch but wait on the trunk?
That's certainly not going onto the branch. If you can get approval, feel free to land on the branch.
Comment on attachment 123527 [details] [diff] [review] all the margins V3 a=asa (on behalf of drivers) for checkin to the 1.4 branch.
checked into branch
Feel free to land this on the trunk as well -- I can handle the merging needed.
Branch build 2003-06-12: Win2k, Mac 10.1.5 Branch build 2003-06-11: Linux RH 8 Marking Verified1.4. It appears that this is fixed on the branch builds. I see a wider right margin versus what is displayed in the trunk builds.