2058525 - Inconsistent color scheme between context menu and its submenu

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[6k64x4ma]

Attachment: image.webp

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:154.0) Gecko/20100101 Firefox/154.0

Steps to reproduce:

1. Go to about:preferences#appearance and select the Light color scheme.
2. Go to about:addons and select the "System theme — auto".
3. Open a new private window.
4. Right-click the content area and hover the cursor over "Ask an AI Chatbot".

Actual results:

The context menu uses the light color scheme, but its submenu uses the dark color scheme.

Expected results:

Context menu and its submenu should use the same color scheme.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a10b5deeb37991bb1ffe41f88949283a13fcc3f8&tochange=d9a81773f05eff9310475ba28c594bc976547165

Regressed by bug 2048186.

Comment 1

[BugBot [:suhaib / :marco]]

:dao, since you are the author of the regressor, bug 2048186, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[6k64x4ma]

The same thing happens with a combination of a dark color scheme and a non-private window.

Comment 3

[Mike Lei]

Attachment: inconsistent background color between context menu levels

Can confirm, I use the [e-mail] color theme to keep the UI of the browser dark, but set the "Website appearance" preference in about:preferences#appearance to light to keep all websites in light mode. I think the context menu is part of the "browser UI" so it should be consistent with the color theme, instead of the appearance of websites. This is a regression and I think it should be reverted.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 2058525 - Make submenus inherit the color scheme of their parent popup. r?emilio!

The generic popup rule sets color-scheme on every popup, submenus included, so
a popup that narrows its scheme couldn't pass that on: the content context
menu follows content's preferred color scheme, but its submenus fell back to
the chrome scheme, which can be the opposite one.

Popups whose parent doesn't narrow the scheme are unaffected, since inheriting
there resolves to the same light dark.

Comment 5

[Dianna Smith [:diannaS]]

:dao what is the severity on this? wondering if worth tracking for 154 or not

Comment 6

[Dão Gottwald [:dao]]

Would be nice to fix in 154 but not critical imho.

Comment 7

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2048186

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d5678f682f3a
https://hg.mozilla.org/integration/autoland/rev/8ef10be6afe3
Make submenus inherit the color scheme of their parent popup. r=emilio,desktop-theme-reviewers

Comment 9

[Mike Lei]

May I ask which way the color of the context menu is aligning to? Is it that after the fix the context menu and its sub-menus will all be controlled by the value of about:preferences#appearance (aka. layout.css.prefers-color-scheme.content-override), or controlled by the color theme of the browser (old behavior before version 154)?

Comment 10

[Dão Gottwald [:dao]]

(In reply to Mike Lei from comment #9)

May I ask which way the color of the context menu is aligning to? Is it that after the fix the context menu and its sub-menus will all be controlled by the value of about:preferences#appearance (aka. layout.css.prefers-color-scheme.content-override), or controlled by the color theme of the browser (old behavior before version 154)?

It's controlled by the content color scheme from about:preferences.

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8ef10be6afe3

Comment 12

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Dão Gottwald [:dao]]

Attachment: Bug 2058525 - Make submenus inherit the color scheme of their parent popup.

The generic popup rule sets color-scheme on every popup, submenus included, so
a popup that narrows its scheme couldn't pass that on: the content context
menu follows content's preferred color scheme, but its submenus fell back to
the chrome scheme, which can be the opposite one.

Popups whose parent doesn't narrow the scheme are unaffected, since inheriting
there resolves to the same light dark.

Original Revision: https://phabricator.services.mozilla.com/D316919

Comment 14

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: see https://bugzilla.mozilla.org/show_bug.cgi?id=2058525#c0
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Trivial CSS-only fix with automated test
• String changes made/needed?: none
• Is Android affected?: no

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/6b9dca0a5394
https://hg.mozilla.org/releases/mozilla-beta/rev/1b656b03ee46