2058565 - The Preferences subdialog stays open after navigating to a different pane

Status: REOPENED

(Firefox :: Settings UI, defect, P3)

Description

[Mark Kennedy [:mark]]

Steps to reproduce

1. Open about:preferences#privacy (or any pane).
2. Open a subdialog (e.g. click Clear Data, or on #manageAddresses click Add address).
3. Paste about:preferences#sync (or the location of any pane other than the one used in Step 1) into the URL bar and press Enter.

Actual
Navigates to the Sync pane, but the previously-opened subdialog stays visible on top of the new pane.

Expected
Navigating away from the pane that opened the subdialog should close the subdialog.

Comment 1

[Mark Kennedy [:mark]]

Attachment: Bug 2058565 - Close open preferences subdialogs when the pane changes r=#reusable-components-reviewers-rotation

This closes any open preferences subdialog when the user navigates to a different pane, either by navigating away through the URL bar or clicking to another pane.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/035328f2ee7a
https://hg.mozilla.org/integration/autoland/rev/dd7d9ecd9228
Close open preferences subdialogs when the pane changes r=hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2b35916e3798
https://hg.mozilla.org/integration/autoland/rev/ee847a685d3c
Revert "Bug 2058565 - Close open preferences subdialogs when the pane changes r=hjones" for causing bc tests failures at creditCard_osAuth.js

Comment 4

[Silaghi Andreea]

Backed out for causing bc tests failures at creditCard_osAuth.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/creditCard/browser_creditCard_osAuth.js | test_osAuth_disabled - uncaught rejection: can't access property "chromeEventHandler", this._window.docShell is null

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dd7d9ecd9228

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a99ef927ea1
https://hg.mozilla.org/mozilla-central/rev/e250d6adf4c0
Revert "Bug 2058565 - Close open preferences subdialogs when the pane changes r=hjones" for causing bc tests failures at creditCard_osAuth.js