Closed Bug 2058718 Opened 1 month ago Closed 10 days ago

[Nova] Sidebar / content is inconsistent with chrome / content gap

Categories

(Firefox :: Sidebar, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: nika, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-post-nova])

Attachments

(4 files)

It appears that the --chrome-window-gap is not being applied consistently on the gap between the primary content and the sidebar. The gap appears visually to be ~twice as large as other gaps (e.g. the gap between the toolbar & web content, or the gap between the sidebar and the window border).

I think it's not quite twice as wide, but perhaps ~2px too wide? Perhaps borders aren't being compensated for?


STR: Open a browser window with Nova enabled, and open the sidebar.

ER: The sidebar gap appears consistent with other gaps

AR: The sidebar gap is approximately 2px wider than other gaps.

FYI, It appears this extra gap also appears in compact mode. I've attached a screenshot of that as well. I'm vaguely guessing that this has the same cause.

Severity: -- → S4
Priority: -- → P2
Summary: [Nova] Gap between sidebar and content appears too wide → [Nova] Sidebar / content is inconsistent with chrome / content gap
Whiteboard: [fidefe-post-nova]

Thank you for the report, Nika!
We'll address it in both modes, however, in the standard / automatic mode, it's the gap between chrome and content that is not up to spec. Both should be 4 px (image attached).

Attached image gaps.png

One other thing I recently noticed, which might be related here, or might be a different bug, is that the spacing between the vertical tab strip and the main content appears to vary depending on whether the window was created already within compact mode, or after toggling from normal mode to compact mode while the browser is running.

e.g. if the window is started in compact mode, there is almost no gap (it looks like the two things are overlapping). If you then toggle to non-compact mode, the objects remain overlapping. I've attached a picture which hopefully should explain what I mean here.

It seems like perhaps some part of this spacing is "sticky" and specified when the window was created, rather than being dynamically dependent on the current state of the window?

Given the recent changes in bug 2063294, there are no longer gaps which need to match. GIven that, I don't think this is a valid bug anymore, and can be closed.

Status: NEW → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: