2058850 - [MacOS] Green dot update available indicator not appearing on the Hamburger menu

Status: VERIFIED FIXED

(Enterprise Products :: Firefox, defect, P1)

Description

[Peter Magyari (Desktop QA)]

Attachment: FxEupdate.png

Found in

• FxE 151.1.0

Affected environment

• Staging

Tested platforms

• Affected platforms: MacOS
• Unaffected platforms: Windows/Ubuntu

Preconditions

• Have an update available
• Have a clean install of FxE.

Steps to reproduce

1. Install an older FxE build.
2. Make sure to turn off your internet connection before starting FELT.
3. After FELT starts up, turn your internet connection back on and log in.
4. Wait for a minute, and check if the green-dot-update-available indicator appears on the hamburger menu icon.

Expected result

• A green dot is displayed on the hamburger menu icon, letting the user know there is an update available.

Actual result

• The green dot indicator does not appear, even though an update is available.

Notes:

• This works as expected on Windows and Ubuntu.

Comment 1

[:gerard-majax]

This is reproducing on nightly as well, right?

Comment 2

[:gerard-majax]

Maybe:

• make sure user_pref("enterprise.log_level", "Debug"); is in your $TMPDIR/felt-<CHANNEL>/user.js

Run from CLI as MOZ_LOG=timestamp,Felt:5,Updates:5 /Application/Firefox\ Enterprise/MacOS/Contents/firefox --jsconsole 2>&1 | tee updates.log should allow to verify when the race happens. I could not reproduce locally when I was trying ...

Comment 3

[Peter Magyari (Desktop QA)]

Attachment: Greendot.png

Run from CLI as MOZ_LOG=timestamp,Felt:5,Updates:5 /Application/Firefox\ Enterprise/MacOS/Contents/firefox --jsconsole 2>&1 | tee updates.log should allow to verify when the race happens. I could not reproduce locally when I was trying ...

This worked, the green dot appeared in a few seconds after logging in.

Comment 4

[:gerard-majax]

(In reply to Peter Magyari (Desktop QA) from comment #3)

Created attachment 9618202 [details]
Greendot.png

Run from CLI as MOZ_LOG=timestamp,Felt:5,Updates:5 /Application/Firefox\ Enterprise/MacOS/Contents/firefox --jsconsole 2>&1 | tee updates.log should allow to verify when the race happens. I could not reproduce locally when I was trying ...

This worked, the green dot appeared in a few seconds after logging in.

That's unfortunately NOT what I was hoping :(

Comment 5

[:gerard-majax]

When you repro, can you verify/confirm/make sure there's no pre-existing process running in background?

Comment 6

[BMO Github Automation]

Attachment: [mozilla/enterprise-firefox] Bug 2058850 - Forward update ready notification when browser is available (#1205)

Comment 7

[:gerard-majax]

I have a patch, assuming what I reproduce in the test case matches what happens in your case. Logs would help ensuring this is the case.

Comment 8

[:gerard-majax]

I'm pushing two draft PRs to produce builds that should allow to test updates:

• https://github.com/mozilla/enterprise-firefox/pull/1210
• https://github.com/mozilla/enterprise-firefox/pull/1211

So you should be able to pick pkg from https://treeherder.mozilla.org/jobs?repo=enterprise-firefox-pr&revision=9a5700fa6b73d753d9118b188b73c98561c7f5c2&searchStr=shippable%2Cmacos&selectedTaskRun=DDDaJBI_RvW53Fhsrr3Lyg.0

The second build is still running so I'll share the link to the mar for it

Comment 9

[:gerard-majax]

the MAR file should be: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dAG3wMZgS0y1c4RsJQx4wg/runs/0/artifacts/public/build/target.complete.mar from https://treeherder.mozilla.org/jobs?repo=enterprise-firefox-pr&selectedTaskRun=dAG3wMZgS0y1c4RsJQx4wg.0&revision=a2acf056dcdd2152a141a7689dda7e6950d6e06d&searchStr=enterprise%2Cshippable%2Cmacos

Comment 10

[:gerard-majax]

The pkg version should report build ID 20260730160416 and the version applied after update should report a build ID 20260730191127

Comment 11

[:gerard-majax]

turns out setting up an update flow test environment is way too much work right now to be a good use of time of QA. Let's land.

Comment 12

[BMO Github Automation]

Authored by Alexandre Lissy
https://github.com/mozilla/enterprise-firefox/commit/944fd01b49ebbcef114e899215825c9a6dc7980d
[enterprise-main] Bug 2058850 - Forward update ready notification when browser is available

Authored by https://github.com/lissyx
https://github.com/mozilla/enterprise-firefox/commit/7ada3d0f6e31a7ba0d45ab2cc5586dea1e9c08ea
[enterprise-main] Merge pull request #1205 from lissyx/enterprise-bug2058850_forward_update_notification_when_ready

Comment 13

[:gerard-majax]

For QA verification after:

• Pick an "old build" that has this patch applied, install it
• Perform STR as documented on comment 0

Comment 14

[Peter Magyari (Desktop QA)]

Verified as fixed on macOS 26.5 using Firefox Enterprise 155.0a1 (20260731152251), with an update available to build (20260803170225), and the green dot update-available indicator appeared correctly on both US and FR builds.