2058917 - URL bar doesn't look great for Document picture in picture window in Nova

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: close up of URL input as first child of toolbar

Steps to reproduce
0. With Nova enabled

1. Navigate to https://mdn.github.io/dom-examples/document-picture-in-picture/
2. Click the toggle button in the page

Actual results

The toolbar does not have any element before the URL bar (see screenshot), and in such case, the border-radius of the URL input feels at odd with the one from the main toolbar (see attached screenshot)

if you customize the toolbar, you can also have the URL bar being the first item in there, but I feel like it's less jarring because you have the tabs on top, or for vertical tabs, you have the window controls, at least on OSX. But maybe this could be an issue on windows/Linux ?

Comment 1

[Drew Willcoxon :adw]

Paul, what do you think?

Comment 2

[Paul (FxUX)]

Attachment: no-toolbar.png

The rounded ends keep on surprising us!

I agree on both counts, these aren't ideal.

There's only one reasonable way I can see of fixing this in the Document PIP version (which isn't something I've come across before), and that's to remove the toolbar-style container from around the address bar, so it sits on the bare chrome. Not ideal, but arguably forgivable as this type of window is a special case, and unlike the main window toolbar it doesn't contain many controls. Would that cause any issues?

(see attached image, but disregard the weird shadow bar on either side)

Other ideas I've considered but discounted would be to increase the corner radius of its toolbar style container, but then it wouldn't match the corner radius of the page container below it, and changing that would then either require the window to have a different corner radius, or the page container would have larger top radii than bottom radii etc etc. Or to reduce the corner radius of the address bar, but then it wouldn't match how it looks everywhere else, so I think that's a non-starter.

So in the case where a user has customized the toolbar to make the address bar the first item, the radius issue is not really fixable – we can't remove the toolbar container in that instance, or change its radius. But at least that positioning is a choice that the user can make (or not make if they don't like it).

Comment 3

[Drew Willcoxon :adw]

Thanks, I'll move this to Toolbars so that team can take a look.