2058922 - test-manifest-toml linter should report issues as line 0, so that they show up in phabricator

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Description

[Mark Banner (:standard8)]

Currently, the test-manifest-toml linter reports the section line number for an error or warning, because tomlkit doesn't report line information (probably this issue).

If I make a change part way down a toml file and that change causes an error or warning, then the issue is not displayed in phabricator because it is reported as line 1, which was not one of the modified lines.

According to the code-review-bot team, we can change the linter to report the line as null, which it will then see as affecting the whole file, and hence report it at the start of the file.

Comment 1

[Mark Banner (:standard8)]

Looking at the code a bit deeper - if a condition has failed, then we do calculate where the condition is, so I wonder if we can do something better for the section titles.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 2058922 - Change the test manifest toml linter to report the sections that are out of order and the line number. r?#linter-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b39f0393b35
https://hg.mozilla.org/integration/autoland/rev/070c5d11dc91
Change the test manifest toml linter to report the sections that are out of order and the line number. r=linter-reviewers,sylvestre

Comment 4

[rperta]

https://hg.mozilla.org/mozilla-central/rev/070c5d11dc91