Closed
Bug 2058970
Opened 2 months ago
Closed 26 days ago
Remove BROWSER_SEARCH_PREF constant
Categories
(Firefox :: Search, task, P3)
Firefox
Search
Tracking
()
RESOLVED
FIXED
157 Branch
| Tracking | Status | |
|---|---|---|
| firefox157 | --- | fixed |
People
(Reporter: scunnane, Assigned: caleb.pickard, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
The BROWSER_SEARCH_PREF constant makes searching for individual browser search prefs more difficult. On balance it probably isn't a useful abstraction. Therefore we can remove it from the search code.
|
Assignee | |
Comment 1•28 days ago
|
||
Hi,
New contributor -- hoping to have a patch for this done soon.
|
|
Assignee | |
Comment 2•28 days ago
|
||
|
|
Assignee | |
Comment 3•28 days ago
|
||
Here's the Phabricator page for the WIP patch. Any tests I should run?
Flags: needinfo?(scunnane)
|
Reporter | |
Updated•28 days ago
|
Assignee: scunnane → caleb.pickard
Flags: needinfo?(scunnane)
|
||
Updated•27 days ago
|
Attachment #9632906 -
Attachment description: WIP: Bug 2058970 - Remove BROWSER_SEARCH_PREF constant. r?scunnane! → Bug 2058970 - Remove BROWSER_SEARCH_PREF constant. r?scunnane!
Pushed by scunnane@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/39b9c330e803
https://hg.mozilla.org/integration/autoland/rev/10c1fe265f7d
Remove BROWSER_SEARCH_PREF constant. r=scunnane,search-reviewers,mconley
|
||
Comment 5•26 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 26 days ago
status-firefox157:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
|
||
Updated•25 days ago
|
QA Whiteboard: [search][qa-triage-done-c157/b156]
You need to log in
before you can comment on or make changes to this bug.
Description
•