2059031 - [Nova] The Address Bar height in Compact mode does not match Figma specifications

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Found in

• Nightly 155.0a1

Affected versions

• Nightly 155.0a1

Tested platforms

• Affected platforms: Windows 11 x64, macOS 26.04, Ubuntu 24.04

Preconditions

• Enable Compact density in about:preferences#appearance.
• Enable the Browser Toolbox by setting devtools.chrome.enabled = true, devtools.debugger.remote-enabled = true

Steps to reproduce

1. Inspect the height of the Address bar using the Browser Toolbox.

Expected result

• The Address bar should match the Figma specifications and be reduce to 28px.

Actual result

• The height of the Address Bar is 26 px.

Regression range

• This is not a regression, it was implemented with the compact mode styling done in Bug 2030953.

Additional notes

• The issue is reproducible with both horizontal and vertical tabs.

Comment 1

[Stephen Thompson [:sthompson]]

Hi :adw, I don't believe our team made codebase changes to the address bar for compact mode. Do you know whether your team's UX specs specify a specific compact UI density height? It does look like Eric Pang from UX on our team did spec 28px height in the overall compact mode spec, but perhaps Eric should talk to your UX partners about how high it should be?

Comment 2

[Drew Willcoxon :adw]

Thanks, nice catch, the problem is that the compact min height is set to 26px here: https://searchfox.org/firefox-main/rev/9d0c7d75f303b16930388cf1b8ef93d161d72c29/browser/themes/shared/urlbar/variables.css#31

We can take Eric's Figma as truth I think because compact mode isn't covered by Paul's search-specific Figma or (at least that I've seen) the Nova Components Figma.

The only design discussion about compact mode has been on Slack, which I documented in bug 2033583.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 2059031 - [Nova] Increase the urlbar's min-height in compact mode.

I'm pretty sure this bug is due to the fact that the border in Nova is actually
an outline inside the urlbar rather than a border outside it. The min-height
needs to take the extra 2px into account.

In the Figma, the height of the input is 28px and does seem to include the
border. The border width is 1, so excluding the border the height is 26px.

Comment 4

[Stephen Thompson [:sthompson]]

OK, that makes sense to me. Thank you for jumping on this!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1a3d807b20cf
https://hg.mozilla.org/integration/autoland/rev/d2fa25258365
[Nova] Increase the urlbar's min-height in compact mode. r=dao,desktop-theme-reviewers,urlbar-reviewers

Comment 6

[rperta]

https://hg.mozilla.org/mozilla-central/rev/d2fa25258365

Comment 7

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 155 on Windows 11, Ubuntu 24.04 and macOS 26 - the URL bar height is increased to 28px.