Closed
Bug 2059104
Opened 2 months ago
Closed 2 months ago
Automate locales update for train-hop
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
155 Branch
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: ini, Assigned: ini)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Summary: New Tab's localized Fluent files (a newtab.ftl per locale) and supported-locales.json are now generated at build time into the objdir and packaged into the XPI, instead of being checked into the source tree and updated by hand before each train-hop.
How it works:
- The locale set is computed at configure time in webext-glue/locales.configure by reading browser/locales/shipped-locales. webext-glue/moz.build iterates that set and drives
GENERATED_FILESrules that run locales/gen_locales.py. - en-US: always packaged from the in-tree copy, so every build includes it with no network access.
- All other locales: packaged only for shipped builds and build-extensions CI, which set
MOZ_BROWSER_NEWTAB_LOCALES_ALL; they are copied from a single firefox-l10n clone fetched once per build and shared across all per-locale outputs. - Escape hatch:
mach newtab update-localesis retained for manual generation and for locally inspecting localization status.
| Assignee | ||
Comment 1•2 months ago
|
||
| Assignee | ||
Comment 2•2 months ago
|
||
| Assignee | ||
Comment 3•2 months ago
|
||
Pushed by mconley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/6231d962b498
https://hg.mozilla.org/integration/autoland/rev/78c7ea4190d2
Generate New Tab train-hop locales at build time and package them into the XPI. r=mconley
https://github.com/mozilla-firefox/firefox/commit/840603f5fd08
https://hg.mozilla.org/integration/autoland/rev/b1435a6cd151
Document build-time New Tab locales generation in train_hopping.md. r=mconley
https://github.com/mozilla-firefox/firefox/commit/c45f535c19d9
https://hg.mozilla.org/integration/autoland/rev/cc38f91c667f
Remove the in-tree New Tab locale snapshots. r=mconley
Comment 5•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/78c7ea4190d2
https://hg.mozilla.org/mozilla-central/rev/b1435a6cd151
https://hg.mozilla.org/mozilla-central/rev/cc38f91c667f
Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox155:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c156/b155]
You need to log in
before you can comment on or make changes to this bug.
Description
•