2059366 - Thick border between notificationbox and RDM toolbar in split view

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: notification box and RDM toolbar displayed in split view tab

In Bug 2056570, we added a border on top of RDM toolbar when there is some notification in split view and Nova is enabled
https://searchfox.org/firefox-main/rev/d573d849c063353bda3a67541ab219c8a548773a/devtools/client/responsive/responsive-browser.css#32-38

/* In Nova, when we have a notification box before the RDM toolbar (in Split View),
   we do want to have a separation between the notifications and the toolbar  */
.notificationbox-stack:not(:empty) + & {
  @media -moz-pref("browser.nova.enabled") {
    border-block-start: 1px solid var(--toolbarseparator-color);
  }
}

Bug 2053689 improved the notficiationbox in Nova, adding a bottom border to it, which means that we now have this "thick" border (the bottom one from the notification, and the top one from the RDM toolbar)
Let's remove the RDM top border

Comment 1

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: Bug 2059366 - [devtools] Small UI refactor for RDM toolbar + notificationbox in Nova. r=#devtools.

Remove the top border on the RDM toolbar now that the notification box has its own bottom border.
Remove inline-end margin and padding on the RDM toolbar close button to align with notification
close buttons.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1b26d1ca450e
https://hg.mozilla.org/integration/autoland/rev/62f6b05207c6
[devtools] Small UI refactor for RDM toolbar + notificationbox in Nova. r=devtools-reviewers,bomsy.

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/62f6b05207c6