2059697 - Dialog top right corner occludes the radiused .browserContainer below it in Nova

Status: RESOLVED FIXED

(Toolkit :: Content Prompts, defect)

Description

[Nicolas Chevobbe [:nchevobbe][PTO - back October 26]]

Attachment: content page with alert dialog

See screenshot: the top right corner doesn't have a radius, while the underlying .browserContainer does have one
This is caused by this declaration https://searchfox.org/firefox-main/rev/7d438b99e58d16388e4327f2460d14ad4c8be075/browser/themes/shared/tabbrowser/content-area.css#947-949,952,954-957

/* Radius the backdrop so it doesnt occlude the radiused .browserContainer below it */
:root:not([inDOMFullscreen]) #tabbrowser-tabbox[sidebar-shown] .dialogOverlay[topmost="true"] {
  @media -moz-pref("sidebar.revamp.round-content-area") {
...
    @media -moz-pref("sidebar.position_start") {
...
      border-start-end-radius: 0;
    }
  }
}

Comment 1

[Nicolas Chevobbe [:nchevobbe][PTO - back October 26]]

Attachment: Bug 2059697 - Fix dialog border radius when Nova is enabled. r=sfoster.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e82d54feb5c2
https://hg.mozilla.org/integration/autoland/rev/0f69a6aa5899
Fix dialog border radius when Nova is enabled. r=sfoster,desktop-theme-reviewers,tabbrowser-reviewers,jswinarton.

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/0f69a6aa5899