Closed Bug 2059710 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 61661 - [Masonry] Add initial column grid-lanes fragmentation

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61661 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61661
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[Masonry] Add initial column grid-lanes fragmentation

Add initial item fragmentation for column grid-lanes containers. The
existing placement pass persists stitched-container offsets for each
lane, then a new fragmentation pass lays out the children belonging to
the current fragment.

Introduce a Flex-inspired item iterator that processes child break
tokens before unstarted items, tracks progress independently for each
lane, and reconstructs continuation state at the start of each
fragment. This makes sure to handle lanes with no items and child
break-token ordering that differs from lane order.

The fragmentation pass converts persisted offsets to fragment-relative
coordinates, creates fragmented child constraint spaces, lays out
continued and unstarted children, and computes the current fragment’s
intrinsic block size.

Rows, spanners, dense-packed items, fragmented subgrids, break rules,
expansion, margins, baselines, and cloned decorations remain follow-up
work.

Add single- and multi-lane WPT coverage adapted from Flex. Existing
grid-lanes-fragmentation-001 still differs because break-inside: avoid
is unsupported and its reference assumes block-style placement
restarting in each fragment.

Bug: 343257585
Change-Id: I4969532dfc154039e39dd074ce14fd47af1fd31f
Reviewed-on: https://chromium-review.googlesource.com/8175168
WPT-Export-Revision: 4f91f4760a602e9811a72efa1d69e21ccd662178

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 17 tests

Status Summary

Firefox

PASS : 5[GitHub] 8[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 4[GitHub] 9[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

CRASH: 1
FAIL : 8

Safari

PASS : 8
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/c4e61aaf7a4d
https://hg.mozilla.org/mozilla-central/rev/e9fd3a0ab62e

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.