2059763 - Filter current device out of connected device section

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Nikki Sharpley (:nikkis) (she/her)]

After the fix for bug 2056253 we now show all devices. We shouldn't show the current device.

STR:

1. Sign in
2. Go the avatar/account menu
3. View all devices

Actual:
ALL devices show

Expected:
The current device should not show

Comment 1

[Stephen Thompson [:sthompson]]

Does this have an impact that you think we should prioritize/fix ASAP?

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 2059763 - Ensure current device is excluded from the fxa menu's connected devices list. r?skhamis!

Comment 3

[Stuart Colville [:muffinresearch]]

[Tracking Requested - why for this release]:

We'd like to get changes into 155 as the accounts changes go out.

Comment 4

[Sam Foster [:sfoster] (he/him)]

A fix for this bug should exclude the current profile from the list. There's a testing gotcha tough - the label we use for a connected device is derived from the machine name and application name, so a different profile on the same machine can appear to be the same as the current one. We don't want to exclude these - sync is between profiles and we support multiple profiles on a given machine.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Seems like a minor polish issue. I'll accept a low-risk uplift for 155/155.0.x but I don't think it needs tracking+ status.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/286e4b5eb02d
https://hg.mozilla.org/integration/autoland/rev/17a8042b446c
Ensure current device is  excluded from the fxa menu's connected devices list. r=skhamis,nsharpley,sync-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/17a8042b446c

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:sfoster, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox155 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 2059763 - Ensure current device is excluded from the fxa menu's connected devices list.

Original Revision: https://phabricator.services.mozilla.com/D319643

Comment 10

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: The extra entries are an annoying and distracting artifact in this menu.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See comment 0: https://bugzilla.mozilla.org/show_bug.cgi?id=2059763#c0
• Risk associated with taking this patch: low
• Explanation of risk level: This is a well contained patch for a minor but distracting issue. The code change is a logic fix in a function dedicated to only this task and no fallout is expected.
• String changes made/needed?: None
• Is Android affected?: no

Comment 11

[Sam Foster [:sfoster] (he/him)]

(In reply to BugBot [:suhaib / :marco] from comment #8)

The patch landed in nightly and beta is affected.
:sfoster, is this bug important enough to require an uplift?

I check with product and we would like this uplifted if the opportunity arises. Its a minor but annoying issue and a really low-risk patch.

Comment 12

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using Firefox build 155.0b5.
Verified as fixed on Win11x64/Mac 15.5/Ubuntu24.04 using Firefox build 157.0a1 and 156.0b1.

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8f348e256314
https://hg.mozilla.org/releases/mozilla-release/rev/476f3a123b66

Comment 14

[Ryan VanderMeulen [:RyanVM]]

(In reply to Pulsebot from comment #13)

Added to the 155.0.1 relnotes.

Comment 15

[Mihai Boldan, Desktop QA [:mboldan]]

Managed to reproduce this issue on Firefox 155.0b5, under Windows 11x64.
Verified as fixed on Win11x64, Mac 10.15, Ubuntu24.04 using Firefox build 155.0.1.