Closed Bug 2059855 Opened 1 month ago Closed 13 days ago

[a11y] Focus is not set to extension permissions prompt dialog

Categories

(Toolkit :: Add-ons Manager, defect, P2)

Firefox 155
Unspecified
Windows 11
defect

Tracking

()

RESOLVED FIXED
156 Branch
Accessibility Severity s2
Tracking Status
firefox155 --- wontfix
firefox156 --- fixed

People

(Reporter: A02291979, Assigned: rpl)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [addons-jira])

Attachments

(2 files)

Impacted Section/Element

About:addons ("Extensions")

Steps to Reproduce

Choose any extension that requires permissions to add, and activate the "Add to Firefox" button on its page. A "Required permissions" dialog will open. Attempt to navigate to the dialog with the keyboard.

Expected Behavior

Focus is set to the dialog container.

Actual Behavior

Focus is not set to the dialog container. There is no way for keyboard users to access the dialog.

User Impact

Keyboard users cannot access the dialog.

WCAG 2.2 References

2.1.1 Keyboard, 2.4.11 Focus Not Obscured

Recommendations

Set focus to the dialog container when it appears.

Testing Environment

Windows 11

Assistive Technology Used

Any

Further Reference

Severity

1-Critical

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Untriaged
Product: Firefox → WebExtensions

The Bugbug bot thinks this bug is an accessibility bug, but please revert this change in case of error.

Keywords: access
Severity: S1 → --
Priority: P1 → --
Component: Untriaged → Add-ons Manager
Product: WebExtensions → Toolkit
Accessibility Severity: --- → s2
Blocks: 2060957
Severity: -- → S1
Priority: -- → P1

This is not an S1 severity bug. Please stop setting it as such. The engineering team responsible for this function will set an appropriate severity level.
https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity

Severity: S1 → --
Priority: P1 → --

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(mixedpuppy)
Flags: needinfo?(mixedpuppy)
Whiteboard: [addons-jira]

The severity field is not set for this bug.
:robwu, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(rob)
Severity: -- → S3
Flags: needinfo?(rob)
Priority: -- → P2
Assignee: nobody → lgreco

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:rpl, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Flags: needinfo?(lgreco)

This patch sets options.autofocus to true for the addon-webext-permissions PopupNotifications doorhanger,
so the focus is moved to the panel on open.

Along with that an additional regression test triggers the panel and asserts that no control is auto-focused
on open.

Severity: S3 → S2
Status: NEW → ASSIGNED
Flags: needinfo?(lgreco)
Summary: [a11y] Focus is not set to dialog → [a11y] Focus is not set to extension permissions prompt dialog
Pushed by luca.greco@alcacoop.it: https://github.com/mozilla-firefox/firefox/commit/785a2bba67ef https://hg.mozilla.org/integration/autoland/rev/f65a368df9c0 Focus the WebExtension permission prompt so users using keyboard navigation can reach it more easily. r=robwu
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch

The patch landed in nightly and beta is affected.
:rpl, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(lgreco)

This was unlikely to be a recent regression, it was more likely like this since when the panel was initially introduced.

I'd personally leave it to ride the 156 release train.

Flags: needinfo?(lgreco)
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: