Closed Bug 2059905 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 61667 - Fix the duplicate-ID expectation in wpt/domxpath/fn-id.html

Categories

(Core :: XSLT, task, P4)

Product:
Core
Component:
XSLT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61667 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61667
Details from upstream follow.

Ryo Hiyoshi <ryohiy.dev@gmail.com> wrote:

Fix the duplicate-ID expectation in wpt/domxpath/fn-id.html

The id("duplicate") subtest expects XPath's id() to return all elements
that share the same ID. However, Chromium's current implementation
returns only the first element, so this subtest is failing. According to
XPath 1.0 section 5.2.1 [1], if two elements have the same unique ID,
the second element must be treated as not having a unique ID. In
addition, every browser listed on wpt.fyi fails this subtest. Therefore,
the test itself is what is wrong.

Update the expectation to match the spec and remove the failure
baseline.

[1] https://www.w3.org/TR/1999/REC-xpath-19991116/#unique-id

Fixed: 422038088
Change-Id: I4796d83f5e57eca80e6122c5627fd43d3c8cfda8

Reviewed-on: https://chromium-review.googlesource.com/8041295
WPT-Export-Revision: 6a45269919c31291f5fa655e4a33a5264c242ef3

Component: web-platform-tests → XSLT
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 34 tests

Status Summary

Firefox

OK : 1[GitHub] 32[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 8[GitHub] 1135[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 21

Chrome

OK : 1
PASS: 8

Safari

OK : 1
PASS: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /domxpath/evaluator-different-document.tentative.html [wpt.fyi]
    • evaluate operation on XML document, context node in HTML document, no namespace resolver: FAIL
    • evaluate operation on HTML document, context node in XML document, no namespace resolver: FAIL
    • evaluate operation on XML document, context node in HTML document, with namespace resolver: FAIL
    • evaluate operation on HTML document, context node in XML document, with namespace resolver: FAIL
  • /domxpath/expression-cross-realm.tentative.html [wpt.fyi]
    • expression from realm with XML associated document, context node in XML document, no namespace resolver: FAIL
    • expression from realm with XML associated document, context node in HTML document, no namespace resolver: FAIL
    • expression from realm with HTML associated document, context node in XML document, no namespace resolver: FAIL
    • expression from realm with HTML associated document, context node in HTML document, no namespace resolver: FAIL
  • /domxpath/expression-different-document.tentative.html [wpt.fyi]
    • expression from XML document, context node in HTML document, no namespace resolver: FAIL
    • expression from HTML document, context node in XML document, no namespace resolver: FAIL
    • expression from XML document, context node in HTML document, with namespace resolver: FAIL
    • expression from HTML document, context node in XML document, with namespace resolver: FAIL
  • /domxpath/fn-lang.html [wpt.fyi]
    • lang("ko"): <root><unmatch xml:lang="Ko"/></root>: FAIL
  • /domxpath/resolver-callback-interface-cross-realm.tentative.html [wpt.fyi]
    • XPathNSResolver is cross-realm plain object without 'lookupNamespaceURI' property: FAIL
    • XPathNSResolver is cross-realm plain object with non-callable 'lookupNamespaceURI' property: FAIL
    • XPathNSResolver is cross-realm non-callable revoked Proxy: FAIL
    • XPathNSResolver is cross-realm callable revoked Proxy: FAIL
    • XPathNSResolver is cross-realm plain object with revoked Proxy as 'lookupNamespaceURI' property: FAIL
  • /domxpath/text-html-attributes.html [wpt.fyi]
    • Select SVG element based on mixed case attribute: FAIL
    • Select both HTML and SVG elements based on mixed case attribute: FAIL
    • Select SVG elements with refX attribute: FAIL

https://hg.mozilla.org/mozilla-central/rev/06b225ff814a
https://hg.mozilla.org/mozilla-central/rev/a93a2c29368a

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.