Open
Bug 2060091
Opened 2 months ago
Updated 14 days ago
Remove unused functions from utils.js in DOM Inspector
Categories
(SeaMonkey :: General, task)
Tracking
(seamonkey2.53? affected)
ASSIGNED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.25)
Attachments
(1 file)
|
6.27 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment utils.js has the following functions that do not seem to be referenced:
- convertChromeURL
- getDSProperty
Whilst here do some tidying up removing unused const, moving a const to where it is still used and make unicodeToEntity similar to the one in browser-content.js
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.25b1pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9620981 -
Flags: review?(frgrahl)
Attachment #9620981 -
Flags: approval-comm-release?
|
||
Updated•14 days ago
|
status-seamonkey2.53:
--- → affected
tracking-seamonkey2.53:
--- → ?
Whiteboard: SM2.53.25
Version: Trunk → SeaMonkey 2.53
|
|
||
Comment 2•14 days ago
|
||
Comment on attachment 9620981 [details] [diff] [review]
2060091-domi-tidy-utils-25325.patch
LGTM.
Nit: const entityVersion = Ci.nsIEntityConverter.entityW3C can be inlined while we are at it Only used in one place.
r/a+ with the nit fixed.
Attachment #9620981 -
Flags: review?(frgrahl)
Attachment #9620981 -
Flags: review+
Attachment #9620981 -
Flags: approval-comm-release?
Attachment #9620981 -
Flags: approval-comm-release+
You need to log in
before you can comment on or make changes to this bug.
Description
•