2060349 - Generalize PNativeLayerRemote to handle non-macOS surfaces

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Brad Werth [:bradwerth]]

To enable GPU process on more platforms, the NativeLayerRemote protocol needs to stop being macOS-specific. The IOSurfacePort is only meaningful for macOS/iOS. The NativeLayerRemote protocol needs a generalized surface union to accommodate other platforms.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 2060349: Change PNativeLayerRemote to use a SurfaceTransfer union.

This changes the macOS-specifc IOSurfacePort into a generic union
SurfaceTransfer, which is a union of platform-specific structures. The
SurfaceTransferMacOS struct has a single IOSurfacePort member. An
alternative hierarchy could define the SurfaceTransfer union with a
collection of platform-specific members. The chosen approach makes clear
which struct is associated with each platform.

This also fixes up usage sites in NativeLayerRemoteMac and in
NativeLayerRootRemoteMacParent.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e26909764555
https://hg.mozilla.org/integration/autoland/rev/d6751e6f64c7
Change PNativeLayerRemote to use a SurfaceTransfer union. r=mstange

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d6751e6f64c7