Open Bug 2060354 Opened 3 months ago Updated 3 months ago

[Tab Groups] When long-pressing the tabs icon in the toolbar, add an "add to to tab group" shortcut

Categories

(Firefox for Android :: Tabs, enhancement)

All
Android
enhancement

Tracking

()

People

(Reporter: jbillman, Unassigned)

References

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(1 file)

Currently, when long-pressing the tabs icon in the toolbar we have shortcuts for:

  • Close tab
  • New private tab
  • New tab

We should also have another shortcut that says "Add tab to group" (use existing verbiage for other areas to perform this action for consistency)

What should the icon be for the "add tab to group" option?

Do we want any telemetry for this new action?

Also, what should happen when "Add tab to group" is selected? Should it open the chooser sheet?

Flags: needinfo?(jbillman)

(In reply to Noah Bond [:007] from comment #1)

What should the icon be for the "add tab to group" option?
We can use the same icon as we do for the Groups screen in the tabs tray

Do we want any telemetry for this new action?
The ideal instrumentation is storing the source under the tab group "created" and "tab added to existing group" events so that rather than any new events, it just adds where it came from to existing events. This is less messy when you can create/add from many places. If at this stage that is problematic, we can simply add an event for when that toolbar shortcut is tapped.

Flags: needinfo?(jbillman)

(In reply to Cathy Lu [:calu] from comment #2)

Also, what should happen when "Add tab to group" is selected? Should it open the chooser sheet?

Yes the chooser sheet where users can select adding to a new or existing tab group.

Attached image image.png —

What position should the "add to group" option be inserted to?

Do we want a confirmation Snackbar?

Depends on: 2061543
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: