2060539 - Don't move to the `AuthIssues` state unless we get confirmation that the refresh token is bad

Status: NEW

(Application Services :: Sync, enhancement, P3)

Description

[Ben Dean-Kawamura [:bdk]]

When we get the CheckAuthorizationStatus event we call the check_authorization_status method, which checks with FxA if our refresh token is valid or not. If that call fails, for example because we get a network error, then we assume the refresh token is bad and move to AuthIssues.

We should switch this logic and only move to AuthIsuues if we get confirmation that the refresh token is invalid, i.e. active=false. On failure, we should log a warning and stay in the from state. This will lead to less users being in AuthIssues when they don't need to be.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 2060539 - errors checking the account state doesn't imply a bad s… (#7541)