[wpt-sync] Sync PR 61721 - Resolve text-decoration-inset overflow and percentages precisely
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 61721 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/61721
Details from upstream follow.
Helmut Januschka <helmut@januschka.com> wrote:
Resolve text-decoration-inset overflow and percentages precisely
Replace the conservative text-decoration-inset ink overflow bounds with
exact bounds: overflow computation now receives the same fragment
context as painting (a line cursor positioned at the current fragment
plus its neighboring fragments), so inset trims and expansions match
the painted decoration exactly. Conservative bounds remain for
marker-driven highlight overflow paths: text-decoration-inset is valid
on highlight pseudo styles, but those paths have no fragment context.Percentage insets with box-decoration-break: slice now resolve against
the total inline size of the decorated run instead of the individual
fragment, by walking the fragment chain in both directions, across
soft-wrapped lines and forced breaks inside the run. Run-edge trims
carry into following or preceding fragments when they exceed a fragment
size, which makes the previously failing WPT tests
text-decoration-inset-028 and -030 pass.Add unit coverage for run-based percentage resolution and inset
accumulation, WPT reftests for single-line and wrapped fragmented runs,
and a WPT invalidation reftest that adds and removes insets (including
negative insets extending beyond the text) after the initial paint.Bug: 539095434, 498974811
Binary-Size: Size increase is unavoidable
Change-Id: I56187b052f7e3eadd8cf7eaf5410772d6edc7491
Fixed: 539095434
Reviewed-on: https://chromium-review.googlesource.com/8148940
WPT-Export-Revision: 02c14d8c38d434050c9f1b142005256bc7646ad5
| Assignee | ||
Updated•3 months ago
|
| Assignee | ||
Comment 1•3 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f05e08c9aeb234bc1aaa6003e6b7344a4e6f9f3b
| Assignee | ||
Comment 2•3 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 362 tests
Status Summary
Firefox
OK : 48
PASS: 2[GitHub] 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1290[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 1574[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 1575[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 1576[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 1[GitHub] 11[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 30[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 31[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
Chrome
PASS: 2
FAIL: 1
Safari
PASS: 2
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-text-decor/invalidation/text-decoration-thickness.html [wpt.fyi]:
PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - /css/css-text-decor/invalidation/selection-pseudo-with-decoration-invalidation-001.html [wpt.fyi]:
FAIL - /css/css-text-decor/invalidation/selection-pseudo-with-decoration-invalidation-002.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-color-selection-pseudo-01.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-color.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-decorating-box-001.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt],PASS[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-text-decor/text-decoration-inset-030.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-inset-percentage-slice.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-text-decor/text-decoration-propagation-display-contents.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-ink-upright-001.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-ink-upright-002.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-001.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-002.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-003.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-004.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-005.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-006.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-007.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-008.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-skip-spaces-009.html [wpt.fyi]:
FAIL - /css/css-text-decor/text-decoration-subelements-004.html [wpt.fyi]:
FAIL - /css/css-text-decor/parsing/text-decoration-skip-spaces-computed.html [wpt.fyi]
- Property text-decoration-skip-spaces value 'none':
FAIL - Property text-decoration-skip-spaces value 'all':
FAIL - Property text-decoration-skip-spaces value 'start':
FAIL - Property text-decoration-skip-spaces value 'end':
FAIL - Property text-decoration-skip-spaces value 'start end':
FAIL
- Property text-decoration-skip-spaces value 'none':
- /css/css-text-decor/parsing/text-decoration-skip-spaces-valid.html [wpt.fyi]
- e.style['text-decoration-skip-spaces'] = "none" should set the property value:
FAIL - e.style['text-decoration-skip-spaces'] = "all" should set the property value:
FAIL - e.style['text-decoration-skip-spaces'] = "start" should set the property value:
FAIL - e.style['text-decoration-skip-spaces'] = "end" should set the property value:
FAIL - e.style['text-decoration-skip-spaces'] = "start end" should set the property value:
FAIL - e.style['text-decoration-skip-spaces'] = "end start" should set the property value:
FAIL
- e.style['text-decoration-skip-spaces'] = "none" should set the property value:
Tests Disabled in Gecko Infrastructure
- /css/css-text-decor/invalidation/text-decoration-thickness.html [wpt.fyi]:
PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview]
Comment 4•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/eee85249974f
https://hg.mozilla.org/mozilla-central/rev/0e123abf51de
Description
•