2060649 - Remove unused BounceTrackingState::ShouldCreateBounceTrackingStateForBC declaration

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P3)

Description

[Emma Zühlcke [:emz]]

BounceTrackingState::ShouldCreateBounceTrackingStateForBC is declared in
toolkit/components/antitracking/bouncetrackingprotection/BounceTrackingState.h but has no definition anywhere in the tree and no callers. A tree-wide search for the identifier returns only that one declaration.

The sibling ShouldCreateBounceTrackingStateForWebProgress is the one actually used, and is declared and defined a few lines away.

Fix: delete the declaration.

Steps

1. Search the tree for ShouldCreateBounceTrackingStateForBC and confirm the single declaration is the only hit.
2. Delete those lines from BounceTrackingState.h.
3. Build with ./mach build and run ./mach test --headless toolkit/components/antitracking/bouncetrackingprotection/test to confirm nothing regressed.

This is a good first bug: self-contained, no behaviour change, and the verification is a single search plus a build.

Comment 1

[Nirmal Advani]

Attachment: Bug 2060649 - Remove unused BounceTrackingState::ShouldCreateBounceTrackingStateForBC declaration r?emz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/70483802e079
https://hg.mozilla.org/integration/autoland/rev/fe8a13040420
Remove unused BounceTrackingState::ShouldCreateBounceTrackingStateForBC declaration r=emz

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/fe8a13040420