[wpt-sync] Sync PR 61728 - [Masonry] Implement flow-tolerance in dense-packing
Categories
(Core :: Layout: Grid, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 61728 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/61728
Details from upstream follow.
Celeste Pan <celestepan@microsoft.com> wrote:
[Masonry] Implement flow-tolerance in dense-packing
This change implements flow-tolerance in dense-packing, and fixes a bug
found where with dense-packing enabled, flow-tolerance was not being
correctly honored. This also adds new tests, to ensure that within
multiple track openings, we will choose the first track opening that is
within flow-tolerance of the minimum.Our implementation of the dense-packing algorithm now requires 2 passes
-- the first to find the absolute minimum running position among the
eligible track openings, and a second to select the first eligible track
opening which is within flow-tolerance of the minimum. Previously,
because we didn't need to account for flow-tolerance, we could just keep
whatever was the absolute minimum running position as our placement
location, but now we have to make sure we're picking the first track we
see in the flow which is within flow-tolerance of the minimum running
position.Applying flow-tolerance to dense-packing uncovers a new bug, where the
second part of a split track opening was not correctly calculated;
column-dense-packing-multi-span-009.htmland
column-dense-packing-001.htmlare split-track-opening-focused tests
which catch this problem.Tests references for
[row|column]-fill-reverse-dense-packing-[definite|indefinite]-size-001.html
were updated, as item 4 should affect the auto-placement cursor, and
even though item 5 does not, that makes track 4 the logical
auto-placement position for item 6, given that it doesn't get densely
packed.[1] https://drafts.csswg.org/css-grid-3/#grid-lanes-layout-algorithm
Bug: 343257585, 517847439
Change-Id: If2fb596867778854c4d9168dfefa3ec217b7ac4e
Reviewed-on: https://chromium-review.googlesource.com/8111177
WPT-Export-Revision: 1524c3da62990436530c4d6de893e739d7675ff9
| Assignee | ||
Updated•3 months ago
|
| Assignee | ||
Comment 1•3 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b96c785ef11556d5cd99ca727c475674e8a0c834
| Assignee | ||
Comment 2•3 months ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 15 tests
Status Summary
Firefox
FAIL: 15
Chrome
PASS: 3
FAIL: 12
Safari
PASS: 4
FAIL: 11
Links
Details
Firefox-only Failures
- /css/css-grid/grid-lanes/item-placement/dense-packing/column-dense-packing-flow-tolerance-003.html [wpt.fyi]:
FAIL - /css/css-grid/grid-lanes/item-placement/dense-packing/row-dense-packing-flow-tolerance-003.html [wpt.fyi]:
FAIL
New Tests That Don't Pass
- /css/css-grid/grid-lanes/item-placement/dense-packing/column-dense-packing-flow-tolerance-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:PASS) - /css/css-grid/grid-lanes/item-placement/dense-packing/column-dense-packing-flow-tolerance-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/column-dense-packing-flow-tolerance-003.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:PASS) - /css/css-grid/grid-lanes/item-placement/dense-packing/column-fill-reverse-dense-packing-definite-size-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/column-fill-reverse-dense-packing-flow-tolerance-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/column-fill-reverse-dense-packing-indefinite-size-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/column-track-reverse-dense-packing-flow-tolerance-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/column-track-reverse-dense-packing-flow-tolerance-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/row-dense-packing-flow-tolerance-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:PASS) - /css/css-grid/grid-lanes/item-placement/dense-packing/row-dense-packing-flow-tolerance-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/row-dense-packing-flow-tolerance-003.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:PASS) - /css/css-grid/grid-lanes/item-placement/dense-packing/row-fill-reverse-dense-packing-definite-size-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/row-fill-reverse-dense-packing-indefinite-size-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/row-track-reverse-dense-packing-flow-tolerance-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/item-placement/dense-packing/row-track-reverse-dense-packing-flow-tolerance-002.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL)
Comment 4•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1801f31fb8f1
https://hg.mozilla.org/mozilla-central/rev/450e7fffc442
Description
•