Fix incorrect origin.name in prosemirror-markdown/moz.yaml
Categories
(Core :: Machine Learning: Frontend, task)
Tracking
()
People
(Reporter: Sylvestre, Unassigned, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=yaml][aiasst])
Filing as a good first bug to learn workflows.
third_party/js/prosemirror/prosemirror-markdown/moz.yaml declares the wrong
library name. Line 13 says:
name: prosemirror-transform
but this manifest describes prosemirror-markdown, not prosemirror-transform.
The description on the next line already says 'ProseMirror Markdown integration',
and there is a separate manifest for prosemirror-transform elsewhere under
third_party/js/prosemirror/.
It should read:
name: prosemirror-markdown
This is the only duplicate origin.name in the whole tree, so the fix also makes
every moz.yaml name unique.
Link to the code:
https://searchfox.org/firefox-main/rev/8b06ce9d88c900e603f97adc49ce04d7adf1cb68/third_party/js/prosemirror/prosemirror-markdown/moz.yaml#13
To verify the fix:
./mach vendor --verify third_party/js/prosemirror/prosemirror-markdown/moz.yaml
You can confirm the duplicate is gone with:
grep -h '^ name:' $(find . -name moz.yaml) | sort | uniq -d
which should print nothing after the change.
The scope is this one line only.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Comment 1•3 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 2•3 months ago
|
||
This code was added in bug 2000992. Redirecting to the Machine Learning: Frontend component to match.
Updated•3 months ago
|
Updated•3 months ago
|
Description
•