[wpt-sync] Sync PR 61749 - Make sure we don't try lookup empty ids in SelectorQuery fast path
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 61749 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/61749
Details from upstream follow.
Rune Lillesveen <futhark@chromium.org> wrote:
Make sure we don't try lookup empty ids in SelectorQuery fast path
Bug: 542447316
Change-Id: I9b5de2f48e06c51857238e175465edc19b7bf49d
Reviewed-on: https://chromium-review.googlesource.com/8194906
WPT-Export-Revision: e44201f7933783647638e737c3f1d4527ed27cc3
| Assignee | ||
Updated•3 months ago
|
| Assignee | ||
Comment 1•3 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=09bd5a0eed0df09c11f1c3531f3b4c99070438d9
| Assignee | ||
Comment 2•3 months ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 353 tests
Status Summary
Firefox
OK : 1[GitHub] 329[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 1[GitHub] 19[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 14926[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 14928[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 14929[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 14935[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
FAIL : 190[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 191[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PRECONDITION_FAILED: 6
TIMEOUT : 1
Chrome
OK : 1
FAIL : 1
Safari
OK : 1
FAIL : 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /dom/nodes/Document-contentType/contentType/contenttype_bmp.html [wpt.fyi]:
SKIP - /dom/nodes/Document-adoptNode-DocumentFragment-with-host.window.html [wpt.fyi]
- adoptNode() <template> element: content follows via template adopting steps:
FAIL
- adoptNode() <template> element: content follows via template adopting steps:
- /dom/nodes/Document-createEvent.https.html [wpt.fyi]
- TouchEvent should be an alias for TouchEvent.:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PRECONDITION_FAILED[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - createEvent('TouchEvent') should be initialized correctly.:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PRECONDITION_FAILED[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - touchevent should be an alias for TouchEvent.:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PRECONDITION_FAILED[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - createEvent('touchevent') should be initialized correctly.:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PRECONDITION_FAILED[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - TOUCHEVENT should be an alias for TouchEvent.:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PRECONDITION_FAILED[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - createEvent('TOUCHEVENT') should be initialized correctly.:
PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PRECONDITION_FAILED[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-32-25h2-debug,Gecko-windows11-32-25h2-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt]
- TouchEvent should be an alias for TouchEvent.:
- /dom/nodes/Node-lookupNamespaceURI.html [wpt.fyi]
- Element has namespace URI matching prefix:
FAIL - Comment should inherit namespace URI matching prefix:
FAIL - Child element should inherit baz namespace:
FAIL - Child element should have null namespace:
FAIL - Child element has namespace URI matching prefix:
FAIL - baz namespace is default for child:
FAIL - childNamespace is default for child:
FAIL - Document should have xhtml namespace, prefix null:
FAIL - Document should have xhtml namespace, prefix "":
FAIL - For document, baz namespace is not default:
FAIL - For document, xhtml namespace is default:
FAIL
- Element has namespace URI matching prefix:
- /dom/nodes/Node-mutation-adoptNode.html [wpt.fyi]
- Adopting an element into a different document update's the element's owner doc as well as the owner docs of it's attributes:
FAIL
- Adopting an element into a different document update's the element's owner doc as well as the owner docs of it's attributes:
- /dom/nodes/ParentNode-replaceChildren.html [wpt.fyi]
- Document.replaceChildren() with an element, replacing an existing doctype and element.:
FAIL - Document.replaceChildren() with a DocumentFragment containing a single element, replacing an existing doctype and element.:
FAIL - Document.replaceChildren() with a doctype, replacing an existing doctype and element.:
FAIL
- Document.replaceChildren() with an element, replacing an existing doctype and element.:
- /dom/nodes/node-realm-adoption-after-frame-removal.html [wpt.fyi]
- Never-wrapped node keeps its creation realm: subtree detached, iframe removed, then adopted:
FAIL - Never-wrapped node keeps its creation realm: iframe removed before adoption (subtree not pre-detached):
FAIL - Node reached through the adopting document still reports its creation realm (frame removed before adoption):
FAIL
- Never-wrapped node keeps its creation realm: subtree detached, iframe removed, then adopted:
- /dom/nodes/node-realm-mixed-across-adoption.html [wpt.fyi]
- Element parsed into an adopted container takes the node-document realm, not the container's creation realm:
FAIL - Text parsed into an adopted container takes the node-document realm, not the container's creation realm:
FAIL - Never-wrapped node keeps its creation realm across multiple adoptions:
FAIL
- Element parsed into an adopted container takes the node-document realm, not the container's creation realm:
- /dom/nodes/node-realm-preserved-across-adoption.html [wpt.fyi]
- Never-wrapped descendant keeps its creation realm after adoption:
FAIL
- Never-wrapped descendant keeps its creation realm after adoption:
- /dom/nodes/node-realm-preserved-across-frameless-adoption.html [wpt.fyi]
- Built-in element from a frameless document keeps its creation realm after adoption:
FAIL - Text node from a frameless document keeps its creation realm after adoption:
FAIL - Comment node from a frameless document keeps its creation realm after adoption:
FAIL - Never-wrapped descendant from a frameless document keeps its creation realm after adoption:
FAIL
- Built-in element from a frameless document keeps its creation realm after adoption:
- /dom/nodes/processing-instruction-attributes.html [wpt.fyi]
- Processing instruction in main parser:
FAIL - Processing instruction attribute parsing rejects unquoted attributes from html-dom:
FAIL - Processing instruction attribute mutation from html-dom:
FAIL - Processing instruction attribute parsing allows _ in attribute names from html-dom:
FAIL - Processing instruction toggleAttribute from html-dom:
FAIL - check attribute value: "=" (source: "html-dom"):
FAIL - check attribute value: "axx"" (source: "html-dom"):
FAIL - check attribute value: "axx>" (source: "html-dom"):
FAIL - check attribute value: "some<>" (source: "html-dom"):
FAIL - check attribute value: "'""'" (source: "html-dom"):
FAIL - check attribute value: "aa"aa"" (source: "html-dom"):
FAIL - Invalid attribute name: = (source: html-dom):
FAIL - Invalid attribute name: a= (source: html-dom):
FAIL - Invalid attribute name: =x (source: html-dom):
FAIL - Invalid attribute name: b> (source: html-dom):
FAIL - Invalid attribute name: > (source: html-dom):
FAIL - Invalid attribute name: >x (source: html-dom):
FAIL - Invalid attribute name: /x/ (source: html-dom):
FAIL - Invalid attribute name: / (source: html-dom):
FAIL - Invalid attribute name: x/ (source: html-dom):
FAIL - Invalid attribute name: x (source: html-dom):
FAIL - Invalid attribute name: x (source: html-dom):
FAIL - Invalid attribute name: x
(source: html-dom):FAIL - Invalid attribute name:
x (source: html-dom):FAIL - Invalid attribute name: x
(source: html-dom):FAIL - Invalid attribute name:
x (source: html-dom):FAIL - Valid attribute name: $ (source: html-dom):
FAIL - Valid attribute name: _ (source: html-dom):
FAIL - Valid attribute name: $foo (source: html-dom):
FAIL - Valid attribute name: _bar (source: html-dom):
FAIL - Valid attribute name: a$b (source: html-dom):
FAIL - Valid attribute name: a_b (source: html-dom):
FAIL - Distinct attribute name (source: html-dom): ABC and abc:
FAIL - Distinct attribute name (source: html-dom): abC and abc:
FAIL - Distinct attribute name (source: html-dom): x123A and x123a:
FAIL - Processing instruction attributes with xml-stylesheet from html-dom:
FAIL - Processing instruction attribute parsing rejects unquoted attributes from html-parser:
FAIL - Processing instruction attribute mutation from html-parser:
FAIL - Processing instruction attribute parsing allows _ in attribute names from html-parser:
FAIL - Processing instruction toggleAttribute from html-parser:
FAIL - check attribute value: "=" (source: "html-parser"):
FAIL - check attribute value: "axx"" (source: "html-parser"):
FAIL - check attribute value: "axx>" (source: "html-parser"):
FAIL - check attribute value: "some<>" (source: "html-parser"):
FAIL - check attribute value: "'""'" (source: "html-parser"):
FAIL - check attribute value: "aa"aa"" (source: "html-parser"):
FAIL - Invalid attribute name: = (source: html-parser):
FAIL - Invalid attribute name: a= (source: html-parser):
FAIL - Invalid attribute name: =x (source: html-parser):
FAIL - Invalid attribute name: b> (source: html-parser):
FAIL - Invalid attribute name: > (source: html-parser):
FAIL - Invalid attribute name: >x (source: html-parser):
FAIL - Invalid attribute name: /x/ (source: html-parser):
FAIL - Invalid attribute name: / (source: html-parser):
FAIL - Invalid attribute name: x/ (source: html-parser):
FAIL - Invalid attribute name: x (source: html-parser):
FAIL - Invalid attribute name: x (source: html-parser):
FAIL - Invalid attribute name: x
(source: html-parser):FAIL - Invalid attribute name:
x (source: html-parser):FAIL - Invalid attribute name: x
(source: html-parser):FAIL - Invalid attribute name:
x (source: html-parser):FAIL - Valid attribute name: $ (source: html-parser):
FAIL - Valid attribute name: _ (source: html-parser):
FAIL - Valid attribute name: $foo (source: html-parser):
FAIL - Valid attribute name: _bar (source: html-parser):
FAIL - Valid attribute name: a$b (source: html-parser):
FAIL - Valid attribute name: a_b (source: html-parser):
FAIL - Distinct attribute name (source: html-parser): ABC and abc:
FAIL - Distinct attribute name (source: html-parser): abC and abc:
FAIL - Distinct attribute name (source: html-parser): x123A and x123a:
FAIL - Processing instruction attribute parsing rejects unquoted attributes from xml-dom:
FAIL - Processing instruction attribute mutation from xml-dom:
FAIL - Processing instruction attribute parsing allows _ in attribute names from xml-dom:
FAIL - Processing instruction toggleAttribute from xml-dom:
FAIL - check attribute value: "=" (source: "xml-dom"):
FAIL - check attribute value: "axx"" (source: "xml-dom"):
FAIL - check attribute value: "axx>" (source: "xml-dom"):
FAIL - check attribute value: "some<>" (source: "xml-dom"):
FAIL - check attribute value: "'""'" (source: "xml-dom"):
FAIL - check attribute value: "aa"aa"" (source: "xml-dom"):
FAIL - Invalid attribute name: = (source: xml-dom):
FAIL - Invalid attribute name: a= (source: xml-dom):
FAIL - Invalid attribute name: =x (source: xml-dom):
FAIL - Invalid attribute name: b> (source: xml-dom):
FAIL - Invalid attribute name: > (source: xml-dom):
FAIL - Invalid attribute name: >x (source: xml-dom):
FAIL - Invalid attribute name: /x/ (source: xml-dom):
FAIL - Invalid attribute name: / (source: xml-dom):
FAIL - Invalid attribute name: x/ (source: xml-dom):
FAIL - Invalid attribute name: x (source: xml-dom):
FAIL - Invalid attribute name: x (source: xml-dom):
FAIL - Invalid attribute name: x
(source: xml-dom):FAIL - Invalid attribute name:
x (source: xml-dom):FAIL - Invalid attribute name: x
(source: xml-dom):FAIL - Invalid attribute name:
x (source: xml-dom):FAIL - Valid attribute name: $ (source: xml-dom):
FAIL - Valid attribute name: _ (source: xml-dom):
FAIL - Valid attribute name: $foo (source: xml-dom):
FAIL - Valid attribute name: _bar (source: xml-dom):
FAIL - Valid attribute name: a$b (source: xml-dom):
FAIL - Valid attribute name: a_b (source: xml-dom):
FAIL - Distinct attribute name (source: xml-dom): ABC and abc:
FAIL - Distinct attribute name (source: xml-dom): abC and abc:
FAIL - Distinct attribute name (source: xml-dom): x123A and x123a:
FAIL - Processing instruction attributes with xml-stylesheet from xml-dom:
FAIL - Processing instruction attribute parsing rejects unquoted attributes from xml-parser:
FAIL - Processing instruction attribute mutation from xml-parser:
FAIL - Processing instruction attribute parsing allows _ in attribute names from xml-parser:
FAIL - Processing instruction toggleAttribute from xml-parser:
FAIL - check attribute value: "=" (source: "xml-parser"):
FAIL - check attribute value: "axx"" (source: "xml-parser"):
FAIL - check attribute value: "axx>" (source: "xml-parser"):
FAIL - check attribute value: "some<>" (source: "xml-parser"):
FAIL - check attribute value: "'""'" (source: "xml-parser"):
FAIL - check attribute value: "aa"aa"" (source: "xml-parser"):
FAIL - Invalid attribute name: = (source: xml-parser):
FAIL - Invalid attribute name: a= (source: xml-parser):
FAIL - Invalid attribute name: =x (source: xml-parser):
FAIL - Invalid attribute name: b> (source: xml-parser):
FAIL - Invalid attribute name: > (source: xml-parser):
FAIL - Invalid attribute name: >x (source: xml-parser):
FAIL - Invalid attribute name: /x/ (source: xml-parser):
FAIL - Invalid attribute name: / (source: xml-parser):
FAIL - Invalid attribute name: x/ (source: xml-parser):
FAIL - Invalid attribute name: x (source: xml-parser):
FAIL - Invalid attribute name: x (source: xml-parser):
FAIL - Invalid attribute name: x
(source: xml-parser):FAIL - Invalid attribute name:
x (source: xml-parser):FAIL - Invalid attribute name: x
(source: xml-parser):FAIL - Invalid attribute name:
x (source: xml-parser):FAIL - Valid attribute name: $ (source: xml-parser):
FAIL - Valid attribute name: _ (source: xml-parser):
FAIL - Valid attribute name: $foo (source: xml-parser):
FAIL - Valid attribute name: _bar (source: xml-parser):
FAIL - Valid attribute name: a$b (source: xml-parser):
FAIL - Valid attribute name: a_b (source: xml-parser):
FAIL - Processing instruction attributes with xml-stylesheet from xml-parser:
FAIL
- Processing instruction in main parser:
- /dom/nodes/insertion-removing-steps/Node-append-meta-referrer-and-script-from-fragment.html [wpt.fyi]
- <meta name=referrer> gets processed and applied in the post-insertion steps:
FAIL
- <meta name=referrer> gets processed and applied in the post-insertion steps:
- /dom/nodes/insertion-removing-steps/Node-appendChild-script-and-default-style-meta-from-fragment.html [wpt.fyi]
- Inserting <meta> that uses alternate stylesheets, applies the style during DOM post-insertion steps:
FAIL
- Inserting <meta> that uses alternate stylesheets, applies the style during DOM post-insertion steps:
- /dom/nodes/insertion-removing-steps/Node-appendChild-script-and-iframe.html [wpt.fyi]
- A script inserted atomically before an iframe (using a div) does not observe the iframe's contentWindow, since the 'script running' and 'iframe setup' both happen in order, after DOM insertion completes:
FAIL - A script inserted atomically before an iframe (using a DocumentFragment) does not observe the iframe's contentWindow, since the 'script running' and 'iframe setup' both happen in order, after DOM insertion completes:
FAIL - A script inserted atomically before an iframe (using a append() with multiple arguments) does not observe the iframe's contentWindow, since the 'script running' and 'iframe setup' both happen in order, after DOM insertion completes:
FAIL
- A script inserted atomically before an iframe (using a div) does not observe the iframe's contentWindow, since the 'script running' and 'iframe setup' both happen in order, after DOM insertion completes:
- /dom/nodes/insertion-removing-steps/Node-appendChild-script-and-style.html [wpt.fyi]
- An earlier-inserted <script> synchronously observes a later-inserted <style> (via a div) being applied:
FAIL - An earlier-inserted <script> synchronously observes a later-inserted <style> (via a DocumentFragment) being applied:
FAIL - Earlier-inserted <script> (via a DocumentFragment) synchronously observes a later-inserted <link rel=stylesheet>'s CSSStyleSheet creation:
FAIL - Earlier-inserted <script> (via a div) synchronously observes a later-inserted <link rel=stylesheet>'s CSSStyleSheet creation:
FAIL - Earlier-inserted <script> (via a append()) synchronously observes a later-inserted <link rel=stylesheet>'s CSSStyleSheet creation:
FAIL
- An earlier-inserted <script> synchronously observes a later-inserted <style> (via a div) being applied:
- /dom/nodes/insertion-removing-steps/Node-appendChild-script-in-script.html [wpt.fyi]
- An outer script whose preparation/execution gets triggered by the insertion of a 'nested'/'inner' script, executes before the inner script executes:
FAIL
- An outer script whose preparation/execution gets triggered by the insertion of a 'nested'/'inner' script, executes before the inner script executes:
- /dom/nodes/insertion-removing-steps/insertion-removing-steps-iframe.window.html [wpt.fyi]
- Insertion steps: load event fires synchronously after iframe DOM insertion, as part of the iframe element's insertion steps:
FAIL - Removing steps (innerHTML): script does not run synchronously during iframe destruction:
FAIL - Removing steps (replaceChildren): script does not run synchronously during iframe destruction:
FAIL - Removing steps (remove): script does not run synchronously during iframe destruction:
FAIL
- Insertion steps: load event fires synchronously after iframe DOM insertion, as part of the iframe element's insertion steps:
- /dom/nodes/insertion-removing-steps/later-script-removed-by-earlier-script.html [wpt.fyi]
- A later-inserted script removed by an earlier-inserted script in the same document fragment should not run:
FAIL - A later-inserted script removed by an earlier-inserted script in the same append() call should not run:
FAIL
- A later-inserted script removed by an earlier-inserted script in the same document fragment should not run:
- /dom/nodes/moveBefore/custom-element-move-reactions.html [wpt.fyi]
- connectedMove runs when custom element is nested within a shadow root:
FAIL
- connectedMove runs when custom element is nested within a shadow root:
- /dom/nodes/moveBefore/preserve-render-blocking-script.html [wpt.fyi]
- A moved script should keep its render-blocking state:
FAIL
- A moved script should keep its render-blocking state:
- /dom/nodes/moveBefore/preserve-render-blocking-style.html [wpt.fyi]
- A moved script should keep its render-blocking state:
FAIL
- A moved script should keep its render-blocking state:
- /dom/nodes/moveBefore/role-updates-after-move.html [wpt.fyi]
- header elements role should become sectionheader when moved into a section:
FAIL
- header elements role should become sectionheader when moved into a section:
- /dom/nodes/moveBefore/selection-preserve.html [wpt.fyi]
- moveBefore should not reset selection with preceding text:
FAIL - moveBefore resets selection that enters a subtree, when the whole selection is moved:
FAIL - moveBefore anchor node moved up to expand selection and absorb nodes:
FAIL - moveBefore focus node moved up to shrink selection and exclude nodes; focus node gets reset:
FAIL - moveBefore selection is not preserved, especially when underlying range gets inverted:
FAIL
- moveBefore should not reset selection with preceding text:
- /dom/nodes/crashtests/multiple-append-mutated-in-unload.https.html [wpt.fyi]:
TIMEOUT - /dom/nodes/remove-from-shadow-host-and-adopt-into-iframe.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt]
Tests Disabled in Gecko Infrastructure
Comment 4•3 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc93414443cc
https://hg.mozilla.org/mozilla-central/rev/7be987cdf4b9
Description
•