2060862 - Prevent `:has()` usage on the main window

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Maybe with an escape hatch for very well reasoned things. The size of the DOM of the main window is very varied depending on the number of open tabs etc, and :has() scales with that in a way it's not easy to optimize, see bug 2054065 for example.

There's virtually always a better way to do things.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2060862 - Add a stylelint rule for :has(). r=dao!,#theme!

See bug 2054065 for an example of what we're trying to prevent.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/50a7e859636a
https://hg.mozilla.org/integration/autoland/rev/6a147be2c1d7
Add a stylelint rule for :has(). r=dao,desktop-theme-reviewers,devtools-reviewers,fxview-reviewers,tabbrowser-reviewers,webcompat-reviewers,urlbar-reviewers,omarg,twisniewski,nchevobbe,jsudiaman,Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1488191e1b5
https://hg.mozilla.org/integration/autoland/rev/66831b35241a
Revert "Bug 2060862 - Add a stylelint rule for :has(). r=dao,desktop-theme-reviewers,devtools-reviewers,fxview-reviewers,tabbrowser-reviewers,webcompat-reviewers,urlbar-reviewers,omarg,twisniewski,nchevobbe,jsudiaman,Gijs" for causing lint failures @ aboutNetError.css

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing lint failures @ aboutNetError.css

Backout link: https://hg.mozilla.org/integration/autoland/rev/66831b35241a2df3c4e2191f0475cfe621a39907

Push with failures

Failures log ->ERROR | /builds/worker/checkouts/gecko/toolkit/themes/shared/aboutNetError.css:223:3 | Unexpected ":has()" selector. It scales with the size of the DOM subtree and needs more complex invalidation and matching than regular selectors.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6fde85fcae9c
https://hg.mozilla.org/integration/autoland/rev/f06e1d57bf64
Add a stylelint rule for :has(). r=dao,desktop-theme-reviewers,devtools-reviewers,fxview-reviewers,tabbrowser-reviewers,webcompat-reviewers,urlbar-reviewers,omarg,twisniewski,nchevobbe,jsudiaman,Gijs

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f06e1d57bf64