2060948 - SW Organize Tabs: Ensure "Just created" only persists for current menu instance

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, defect, P1)

Description

[:jlewis]

The "Organize Tabs" panel lists every group the feature created in this window under "Just created", with an "Ungroup Tabs" row that dissolves all of them at once.

Only persist groups as "Just created" during the menu instance (ie create group > group appears as just created > close and reopen menu > group no longer there)

Comment 1

[:jlewis]

Attachment: Bug 2060948 - SW Organize Tabs: Ensure "Just created" only persists for current menu instance

The "Just created" list outlived the panel that filled it: it was only
ever cleared by the "Ungroup Tabs" row, by a group disappearing, or by
the window closing, so groups from earlier in the session kept showing up
and the bulk ungroup kept reaching back to them.

Empty it as the panel tears down. The card already hides the heading, the
rows and the "Ungroup Tabs" row when the list is empty, and this also
drops our references to the created groups once the panel is gone.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d4fa5af3e53e
https://hg.mozilla.org/integration/autoland/rev/59c35c7cb010
SW Organize Tabs: Ensure "Just created" only persists for current menu instance r=echa

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/59c35c7cb010

Comment 4

[:jlewis]

Attachment: Bug 2060948 - SW Organize Tabs: Ensure "Just created" only persists for current menu instance

Auto Tab Grouping / 'Organize Tabs'

Spec: https://docs.google.com/spreadsheets/d/1eEDfKdPECzFYQm5_gkIz8lG_t32VPrCQwO-ZMvJpUpM/edit?gid=0#gid=0

Original Revision: https://phabricator.services.mozilla.com/D316608

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes small UI bug in Smart Window's Auto Tab Grouping feature, stabilizes for v0

• Code covered by automated testing?: yes

• Fix verified in Nightly?: yes

• Needs manual QE testing?: yes

• Steps to reproduce for manual QE testing: browser.smartwindow.autoTabGrouping.enabled to true

  • Open a bunch of tabs
  • Create a tab group
  • See that tab group appears in menu's 'Just created' section, with option to ungroup underneath
  • Close and reopen menu
  • Tab group should no longer be there, 'Just created' and 'Ungroup' sections should not appear if no groups are there.

• Risk associated with taking this patch: medium

• Explanation of risk level: Actual code implementation is pretty small. Feature is gated behind a pref, so only user base is those foxfooding at the moment

• String changes made/needed?: N/A

• Is Android affected?: no

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ab889d62a2a9
https://hg.mozilla.org/releases/mozilla-beta/rev/434051d183e5

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Release 154.0.1 and our latest Beta 155.0b3