2060959 - SW ATG: Suggested group's hover state lingers when moving to another Organize Tabs menu item

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, defect, P1)

Description

[:jlewis]

When hovering from a suggested tab group to either the "Create Groups" or "Ungroup Tabs" buttons, there is a bit of stickiness - the hover effect on the suggested tab group persists for a bit too long.

Hovering the other way around (from "Create Groups" or "Ungroup Tabs" to the suggested tab group) clears their hover state immediately on mouseleave, which is as intended.

Expected: the suggested group's hover state disappears as soon as the pointer moves to another item in the Organize Tabs menu.

Comment 1

[:jlewis]

Attachment: Bug 2060959 - SW ATG: Suggested group's hover state lingers when moving to another Organize Tabs menu item

Auto Tab Grouping / 'Organize Tabs'

Spec: https://docs.google.com/spreadsheets/d/1eEDfKdPECzFYQm5_gkIz8lG_t32VPrCQwO-ZMvJpUpM/edit?gid=0#gid=0

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dd973208f1c5
https://hg.mozilla.org/integration/autoland/rev/c40831b012cc
SW ATG: Suggested group's hover state lingers when moving to another Organize Tabs menu item r=flozia

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c40831b012cc

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: This fixes a small focus issue on the Auto Tab Grouping menu, which is part of Smart Window
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: In Nightly: flip browser.smartwindow.autoTabGrouping.enabled to true in a Smart Window

Open multiple tabs, open Auto Tab Grouping menu, change hover between a suggested tab group and another ATG menu item (e.g. create all groups). The hover effect will linger and feel sticky.

This patch rectifies that.

• Risk associated with taking this patch: low
• Explanation of risk level: Small code change, only a few lines applied to a pref-gated feature in Smart Window.
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 5

[:jlewis]

Attachment: Bug 2060959 - SW ATG: Suggested group's hover state lingers when moving to another Organize Tabs menu item

Auto Tab Grouping / 'Organize Tabs'

Spec: https://docs.google.com/spreadsheets/d/1eEDfKdPECzFYQm5_gkIz8lG_t32VPrCQwO-ZMvJpUpM/edit?gid=0#gid=0

Original Revision: https://phabricator.services.mozilla.com/D316614

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e4d3e0a480c6
https://hg.mozilla.org/releases/mozilla-beta/rev/c3b3e6b682d9

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Release 154.0.1 and our latest Beta 155.0b3