2060967 - Crash stacks not linking to searchfox

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P3)

Description

[Steve Fink [:sfink] [:s:]]

Crash stacks now seem to have links to github. I believe they went to mercurial before? I would still prefer searchfox. (Related: bug 1651813 is an older bug asking to switch from hg.m.o -> searchfox.)

For example: instead of or in addition to
https://github.com/mozilla-firefox/firefox/blob/ed6cfb3b73cb602ed2b8a75b1721c95b8e820322/dom/base/StructuredCloneBlob.cpp#L253
I would like
https://searchfox.org/firefox-main/rev/ed6cfb3b73cb602ed2b8a75b1721c95b8e820322/dom/base/StructuredCloneBlob.cpp#253

I used github's search to try to find it, and it'd be something like the github one: https://github.com/%(repo)s/blob/%(revision)s/%(file)s#L%(line)s except it'd be https://searchfox.org/%(notrepo)s/rev/%(revision)s/%(file)s#%(line)s except I don't know what notrepo should be and I don't want to dig up the user right now. (Nor do I know if it'd be ok to use searchfox as a "VCS".) Maybe if mozilla-services were indexed by searchfox... ;-)

Comment 1

[Bianca Danforth [:bdanforth]]

Thank you for filing this. We obtain this information from the symbols files, so this is not something we control directly. gsvelto: is this a change that was made upstream recently?

Comment 2

[Gabriele Svelto [:gsvelto]]

We last changed the paths in bug 1987761. Personally I'd be in favor of them going to searchfox.org as that's what I use whenever I look at crash stats, but I don't know if there would be downsides to this outside of searchfox uptime (which is currently higher than GitHub, mostly because of GH's consistent degradation in the last couple of years). Markus, what do you think?

Comment 3

[Sven Marnach :sven]

Maybe someone interested in this can spin up a Firefox extension that translates the links on the client side? We won't have the bandwidth to do this, but it would give people a choice, and if Searchfox is down they can simply disable the extension.

Comment 4

[Markus Stange [:mstange]]

(In reply to Gabriele Svelto [:gsvelto] from comment #2)

Markus, what do you think?

I also think linking to searchfox is preferable over linking to github. The URL translation should be straightforward. Comment #0 has it for the mozilla-firefox/firefox repo; I'm not sure if that would immediately work for release branches as well but it's probably not hard to find out.

Comment 5

[Markus Stange [:mstange]]

https://github.com/mozilla-services/socorro/pull/7248

Comment 6

[Sven Marnach :sven]

Thanks for the PR! I'll move this ticket back into the Socorro product, since this is where we ended up fixing this.

Comment 7

[Sven Marnach :sven]

I merged the PR (which took a few attempts due to GitHub issues).

Comment 8

[Sven Marnach :sven]

I tested this in stage with a few crashes. I compared where the links took me for the same crash in prod, and it's all looking good. Some links go to surprising lines, e.g. the link for arena_dalloc(void*, unsigned long, arena_t*) in frame 25 of https://crash-stats.mozilla.org/report/index/cdc13f88-7e67-4eb7-aad8-b7ee00260825 is https://searchfox.org/firefox-main/rev/017a9913bd6c272a859aea16d3cab5a4d46bf1b0/memory/build/mozjemalloc.cpp#2737, which is not what I'd expect, but it's the same line using the old GitHub link, so the behaviour isn't caused by this patch. I'll go ahead and deploy it to prod.

Comment 9

[Sven Marnach :sven]

This was deployed to production with https://github.com/mozilla-services/socorro/releases/tag/v2026.08.26, and appears to be working fine there as well.